Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routing of each Installed Card to its Respective Main Page #337

Closed
wants to merge 10 commits into from

Conversation

hokagedemehin
Copy link
Contributor

@hokagedemehin hokagedemehin commented Sep 2, 2021

Before submitting your PR for review

  • Run npm run eslint to find errors in code syntax/format
  • Run npm run eslint:fix to fix all auto-fixable errors in source code and auto-format with prettier
  • Ensure you fix any linting errors displayed after running any of the above commands
  • Ensure you fix all merge conflicts before sending PR

Live Link

Click here for live link

What does this PR do?

Answer: Fixes issue #315

Summarise the main tasks handled in the pull request

Answer: The main task involves directing the user to the main page of each installed card when clicked

Description of Task to be completed?

Describe (in detail) what the task completed in the pull request does as per the relevant task

Answer: Once the user is at the main page of the external tools plugin, he or she will be able to see all of their installed apps in their respective workspace, and when they click the app's card, it will take them to the main page of that particular app they clicked, where they can view more details about the app when needed

How should this be manually tested?

Give bullet point instructions on how to set up the code and test it manually (Assume no prior experience on JS or code)

Any background context you want to provide?

Any pertinent information that should be considered

What is the link to the issue on Github?

Issue #315

Questions:

If something is unclear or you want some questions to be addressed by your peers, mention them here

@Davien21
Copy link
Contributor

Davien21 commented Sep 3, 2021

merge conflicts choke. also you did more than the title of this PR

@Davien21 Davien21 closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants