Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ZCH-59): add zupit icon #28

Merged
merged 7 commits into from
May 10, 2024
Merged

feat(ZCH-59): add zupit icon #28

merged 7 commits into from
May 10, 2024

Conversation

deyan-koba-zupit
Copy link
Contributor

Checklist before requesting a review

  • I have performed a self-review of my code
  • Does the code follow the team's coding standards and best practices?
  • Are there any duplicated code blocks that can be refactored into reusable functions?
  • Are there tests on the new code?
  • Does the PR implement the intended functionality or fix the issue described in the title and description?
  • Is the PR title clear and detailed enough to provide necessary context?
  • Have the changes passed the CI/CD pipeline?
  • Will the changes have any adverse effects on other parts of the system and do they work well with other existing features?

Copy link

nx-cloud bot commented May 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 54b70e0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@deyan-koba-zupit deyan-koba-zupit marked this pull request as draft May 7, 2024 11:49
@deyan-koba-zupit deyan-koba-zupit marked this pull request as ready for review May 8, 2024 09:22
@deyan-koba-zupit deyan-koba-zupit requested review from omar-muscatello-zupit and removed request for omar-muscatello-zupit May 9, 2024 08:10
Copy link
Member

@alessio-libardi-zupit alessio-libardi-zupit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I

tsconfig.base.json Outdated Show resolved Hide resolved
@omar-muscatello-zupit omar-muscatello-zupit merged commit 5c191f3 into main May 10, 2024
7 checks passed
@omar-muscatello-zupit omar-muscatello-zupit deleted the zupit-icon branch May 10, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants