Fix: Foreign Affairs update front-end. #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbeJellinek
requested changes
Jan 9, 2025
Foreign Affairs.js
Outdated
| let authors = author.split(/, and|and |, /); | ||
| for (let aut of authors) { | ||
| item.creators.push(ZU.cleanAuthor(aut, "author")); | ||
| } | ||
|
|
||
| var tags = doc.querySelectorAll('.mr-15'); |
There was a problem hiding this comment.
Not a reliable selector (this is a Tailwind margin style) - anything else we can match on?
There was a problem hiding this comment.
Changed to:
var tags = doc.querySelectorAll(
'a[href^="/regions/"].text-decoration-none, ' +
'a[href^="/topics/"].text-decoration-none, ' +
'a[href^="/tags/"].text-decoration-none'
);There was a problem hiding this comment.
This is still matching on a Tailwind class, so still unstable. Anything else we could use? Do we need the class in the selector at all?
There was a problem hiding this comment.
Like:
var tags = doc.querySelectorAll(`
ul > li > a[href^="/regions"],
ul > li > a[href^="/topics"],
ul > li > a[href^="/tags"]
`);?
There was a problem hiding this comment.
Thanks for the comment. I now change to the style as suggested.
var tags = doc.querySelectorAll(
'main > div > div > div > div > ul > li > a[href^="/regions/"], ' +
'main > div > div > div > div > ul > li > a[href^="/topics/"], ' +
'main > div > div > div > div > ul > li > a[href^="/tags/"]'
);There was a problem hiding this comment.
That isn't really what I suggested, but I see that what I suggested would've matched non-tag links. Just pushed an update to fix that.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, Foreign Affairs changed its front-end code, so the previous translator no longer works. See test pages:
http://www.foreignaffairs.com/issues/2012/91/01
https://www.foreignaffairs.com/reviews/capsule-review/2003-05-01/history-argentina-twentieth-century
https://www.foreignaffairs.com/search/argentina
I have updated the translator to accommodate the new layout for all these three types of pages. All tests are passed. Could you kindly review the pull request and merge it if it's fine? Many thanks!
I have posted this issue on the Zotero forum: https://forums.zotero.org/discussion/120979/translator-for-foreign-affairs-needs-update