Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Add support for Python 3.12. - Drop support for Python 3.7. #17

Merged
merged 8 commits into from
Sep 27, 2024
Merged

- Add support for Python 3.12. - Drop support for Python 3.7. #17

merged 8 commits into from
Sep 27, 2024

Conversation

icemac
Copy link
Member

@icemac icemac commented Jul 15, 2024

Fix test in GHA.

@icemac
Copy link
Member Author

icemac commented Jul 15, 2024

Failed to pin setuptools to < 69: It gets ignored an setuptools==70.1.0 is used for most Python versions. (Python 3.12 succeeds while using setuptools==70.3.0, which is also strange.)

So let's wait for buildout/buildout#649 to be merged and released, which allows setuptools >= 70.

@icemac icemac added the help wanted Extra attention is needed label Jul 17, 2024
@icemac icemac closed this Sep 26, 2024
@icemac icemac reopened this Sep 26, 2024
@icemac icemac removed the help wanted Extra attention is needed label Sep 26, 2024
@icemac icemac requested a review from dataflake September 26, 2024 07:15
dataflake
dataflake requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with that setuptools pin in setup.py and why < 69?

CHANGES.rst Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@dataflake
Copy link
Member

I removed the pin (and change log entry for it) and everything's still green.

@icemac
Copy link
Member Author

icemac commented Sep 27, 2024

Thank you for reviewing this PR. 😃

@icemac icemac merged commit 898dce9 into master Sep 27, 2024
15 checks passed
@icemac icemac deleted the config-with-buildout-recipe-template-6e808865 branch September 27, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataflake dataflake dataflake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icemac @dataflake