Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire Python 3.8 #291

Merged
merged 3 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ jobs:
config:
# [Python version, tox env]
- ["3.11", "release-check"]
- ["3.8", "py38"]
- ["3.9", "py39"]
- ["3.10", "py310"]
- ["3.11", "py311"]
Expand Down
2 changes: 1 addition & 1 deletion .meta.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# https://github.com/zopefoundation/meta/tree/master/config/pure-python
[meta]
template = "pure-python"
commit-id = "7565cacd"
commit-id = "96809911"

[python]
with-windows = false
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ repos:
rev: v3.19.0
hooks:
- id: pyupgrade
args: [--py38-plus]
args: [--py39-plus]
- repo: https://github.com/isidentical/teyit
rev: 0.4.3
hooks:
Expand Down
2 changes: 2 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Change log
1.1 (unreleased)
----------------

- Drop support for Python 3.8.

- Allow specifying a minimum supported Python version other than the previously
hardcoded default of Python 3.8.

Expand Down
4 changes: 2 additions & 2 deletions docs/narr.rst
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ The following options are only needed one time as their values are stored in

--oldest-python
The oldest version of Python supported by this package. Specified as version
number, e.g. ``3.8``. This setting is optional and defaults to the lowest
number, e.g. ``3.12``. This setting is optional and defaults to the lowest
Python version generally supported by zopefoundation packages.

--with-docs
Expand Down Expand Up @@ -300,7 +300,7 @@ updated. Example:
" image: postgres",
]
additional-config = [
"- [\"3.8\", \"py38-slim\"]",
"- [\"3.12\", \"py312-slim\"]",
]
additional-exclude = [
"- { os: windows, config: [\"pypy-3.10\", \"pypy3\"] }",
Expand Down
3 changes: 1 addition & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def read(*rnames):
'License :: OSI Approved :: Zope Public License',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
'Programming Language :: Python :: 3.10',
'Programming Language :: Python :: 3.11',
Expand Down Expand Up @@ -75,7 +74,7 @@ def read(*rnames):
'tox',
'zest.releaser',
],
python_requires='>=3.8',
python_requires='>=3.9',
include_package_data=True,
zip_safe=False,
extras_require={
Expand Down
2 changes: 1 addition & 1 deletion src/zope/meta/c-code/tests.yml.j2
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
# native support. It works, but is slow.
#
# Another major downside: You can't just re-run the job for one part
# of the matrix. So if there's a transient test failure that hit, say, 3.8,
# of the matrix. So if there's a transient test failure that hit, say, 3.11,
# to get a clean run every version of Python runs again. That's bad.
# https://github.community/t/ability-to-rerun-just-a-single-job-in-a-workflow/17234/65

Expand Down
4 changes: 2 additions & 2 deletions src/zope/meta/shared/packages.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
TYPES = ['buildout-recipe', 'c-code', 'pure-python', 'zope-product', 'toolkit']
ORG = 'zopefoundation'
BASE_PATH = pathlib.Path(__file__).parent.parent
OLDEST_PYTHON_VERSION = '3.8'
OLDEST_PYTHON_VERSION = '3.9'
NEWEST_PYTHON_VERSION = '3.13'
FUTURE_PYTHON_VERSION = '3.14'
PYPY_VERSION = '3.10'
Expand Down Expand Up @@ -155,7 +155,7 @@ def supported_python_versions(oldest_version=OLDEST_PYTHON_VERSION,

Kwargs:
oldest_version (str):
The oldest supported Python version, e.g. '3.8'.
The oldest supported Python version, e.g. '3.9'.

short_version (bool):
Return short versions like "313" instead of "3.13". Default False.
Expand Down
1 change: 0 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ minversion = 3.18
envlist =
release-check
lint
py38
py39
py310
py311
Expand Down
Loading