Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin setuptools again #243

Merged
merged 1 commit into from
May 24, 2024
Merged

Pin setuptools again #243

merged 1 commit into from
May 24, 2024

Conversation

dataflake
Copy link
Member

Pin setuptools so...

  • source distributions don't get dotted names replaced by underscores
  • zc.buildout compatibility issues

@dataflake dataflake requested a review from icemac May 23, 2024 07:09
@dataflake dataflake mentioned this pull request May 23, 2024
Closed
@icemac icemac force-pushed the dataflake/pin-setuptools-again branch from abeb12a to 7bca00e Compare May 24, 2024 06:37
icemac
icemac approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I already sprinkled some setuptools < 69 onto master as I thought this PR is already merged.

@icemac icemac merged commit 4dc0484 into master May 24, 2024
3 checks passed
@icemac icemac deleted the dataflake/pin-setuptools-again branch May 24, 2024 06:38
@icemac icemac mentioned this pull request May 24, 2024
Merged
@tseaver tseaver mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemac icemac icemac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dataflake @icemac