Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address issues from PR #216 #221

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Address issues from PR #216 #221

merged 2 commits into from
Oct 26, 2023

Conversation

dataflake
Copy link
Member

This PR addresses the issues found after merging #216.

  • prescribe Python 3.11 for using this package
  • fix documentation to rename maccabe to mccabe
  • fix documentation wording for flake8 additional-plugins
  • add release-check test to GHA steps

@dataflake dataflake requested review from icemac and d-maurer October 23, 2023 08:24
@dataflake dataflake self-assigned this Oct 23, 2023
d-maurer
d-maurer approved these changes Oct 23, 2023
View reviewed changes
Copy link

@d-maurer d-maurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the strangely unbalanced [] I am fine.

config/default/tests.yml.j2 Outdated Show resolved Hide resolved
@dataflake dataflake merged commit 6f8d8c5 into master Oct 26, 2023
4 checks passed
@dataflake dataflake deleted the fixup_pr_216 branch October 26, 2023 14:13
@icemac icemac mentioned this pull request Dec 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-maurer d-maurer d-maurer approved these changes

@icemac icemac Awaiting requested review from icemac

Assignees

@dataflake dataflake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dataflake @d-maurer