-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support of Python 3.7 #217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with merging this PR because all it does is change the drop-legacy-python
script. I don't know anyone who uses that script after Python 2 support has been removed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This script has to be adapted to be useable to actually drop Python 3.7 support. It was already used on all zopefoundation packages to drop Python 2.7 to 3.6 support, so this part is no longer needed and the change log messages should not mention it any more.
But really dropping Python 3.7 support also means to adapt all the templates and remove 3.7 from tox.ini, the c code build scripts etc.
Maybe the script should be reworked into one adding support for new version (aka 3.12) + the already existing dropping of outdated versions. |
If for nothing else than a tiny contribution to reducing our carbon footprint, can we please quit doing CI on EOL Python versions as a matter of policy? Under current rules, that would give us five "stable" Python versions to test, plus the one in alpha/beta for the succeeding release. |
I think the time has come to rework the templates in order to get rid of Python 3.7. I'm going to extend this PR soon. |
@icemac I have removed references to the |
@dataflake Do you envision to no longer to use |
I don't use that script, for me the only use would be as a scripting example. |
For completeness sake: this is fine from a Plone standpoint. |
Remove Python 3.7 from list of supported Python Versions, as of today (2023-10-07) Python 3.7 is already end of Life (since 2023-06-27). See https://devguide.python.org/versions/ for reference.
See also #200.