-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tomlkit for TOML read/write operations #215
Conversation
Instead of changing the behavior of |
We can also do it this way, but it actually does not use the capabilities of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks okay to me, although we might end up with all default values in the meta.toml
now.
I was thinking about that and to be honest I don't think that's a bad thing. It's very explicit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally I got to this PR.
Thank you for this PR. 😃 |
This PR is an alternative to #209. It does two things:
toml
use withtomlkit
requirements.txt
to the latest versions that still support Python 3.7Running this code against current Zope yields the following diff in
.meta.toml
:The different is most likely due to the change in the
_set_python_config_value
method where I always use the defaultFalse
because some values wereNone
at that point, whichtomlkit
didn't like.