Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkg_resources dependency #259

Merged
merged 2 commits into from
Aug 9, 2024
Merged

Remove pkg_resources dependency #259

merged 2 commits into from
Aug 9, 2024

Conversation

lcjohnso
Copy link
Member

Closes #257

Following recommendations from the pkg_resources devs, replacing its use to extract package versions by swapping in importlib.metadata package. I also added requests and urllib3 to the CLI's info() function to aid in future debugging.

@lcjohnso lcjohnso requested a review from Tooyosi August 9, 2024 04:06
Copy link

@Tooyosi Tooyosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcjohnso lcjohnso merged commit aab42a0 into master Aug 9, 2024
2 checks passed
@lcjohnso lcjohnso deleted the remove-pkgresources branch August 9, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.12 "no module pkg_resources"
2 participants