Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header links #96

Merged
merged 3 commits into from
Sep 5, 2024
Merged

fix: header links #96

merged 3 commits into from
Sep 5, 2024

Conversation

itsacoyote
Copy link
Contributor

Description

Update docs-nuxt-template to fix the missing main nav links.
Also attempting to fix icons alongside this.

Copy link

github-actions bot commented Sep 5, 2024

Visit the preview URL for this PR (updated for commit 6c0724d):

https://zksync-sdk-docs-staging--pr96-fix-header-jlgibh5p.web.app

(expires Thu, 12 Sep 2024 17:47:31 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f6539d831ccfa61081c09db66b409eadb94db989

Copy link

@cpb8010 cpb8010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, having an empty link list would break links so just defaulting would be better?
The icon packages and removed helper seems fair if it still compiles!

@itsacoyote itsacoyote merged commit 562f56c into main Sep 5, 2024
9 checks passed
@itsacoyote itsacoyote deleted the fix-header branch September 5, 2024 21:06
Copy link

github-actions bot commented Sep 5, 2024

🎉 This PR is included in version 1.19.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants