Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 3 update #1

Merged
merged 4 commits into from
May 19, 2023
Merged

Ruby 3 update #1

merged 4 commits into from
May 19, 2023

Conversation

chris-nelson-mn
Copy link

@chris-nelson-mn chris-nelson-mn commented May 18, 2023 •
edited
Loading

Majority of changes originate from dball#16

Adds support for Ruby 3, plus some refactoring. Adds Github actions config to run test suite.

allantokuda-zipnosis
allantokuda-zipnosis approved these changes May 19, 2023
View reviewed changes
Copy link

@allantokuda-zipnosis allantokuda-zipnosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a test where I grabbed an image URI, ran it through the class, output the raw data to a new JPG file and was able to open it and see it again.

@chris-nelson-mn chris-nelson-mn merged commit af579fe into master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allantokuda-zipnosis allantokuda-zipnosis allantokuda-zipnosis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chris-nelson-mn @allantokuda-zipnosis @kfprimm @ChrisNelsonBHG