Minor optimizations for ZPure's runloop #1474
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across a few things in the ZPure runloop that could be optimized since it was initially rewritten about a year ago.
Main changes:
Flag
and replace it withClearLogOnError
in order to avoid pattern matching on the flag type in the runloopreturn Left(err)
instead of throwing an exception and catching it later. This is more optimized as the C2 compiler doesn't optimize branches when an exception is thrown (even if it doesn't fill stack-traces). We saw this previously in ZIO where we used to throw an exception for yielding in the runloop (which was then replaced by returning null instead)val
s (which we previously needed just to call.asInstanceOf
on).