Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-scalajs, scalajs-compiler, ... to 1.18.2 #1462

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

zio-scala-steward[bot]
Copy link
Contributor

About this PR

📦 Updates

from 1.17.0 to 1.18.2

📜 GitHub Release Notes - Version Diff

Usage

Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

⚙ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-js" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-js" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, commit-count:1

@guizmaii
Copy link
Member

guizmaii commented Feb 6, 2025

Error reported to ScalaJS scala-js/scala-js#5127

@@ -198,12 +198,12 @@ new _root_.zio.prelude.QuotedAssertion[${c.weakTypeOf[A]}] {
val (_, _, codeString) = text(f)
q"""
new _root_.zio.prelude.QuotedAssertion[${c.weakTypeOf[A]}] {
@_root_.zio.prelude.assertionLambdaQuote($f)
@_root_.zio.prelude.assertionLambdaQuote(${c.untypecheck(f)})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this c.untypecheck thing is doing.
Comes from suggestion made here: scala-js/scala-js#5127 (comment)

@guizmaii guizmaii enabled auto-merge (squash) February 7, 2025 04:05
@guizmaii guizmaii merged commit 655bd4a into series/2.x Feb 7, 2025
21 checks passed
@guizmaii guizmaii deleted the update/sbt-scalajs-1.18.2 branch February 7, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant