Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal #37

Open
wants to merge 81 commits into
base: release24
Choose a base branch
from
Open

Internal #37

wants to merge 81 commits into from

Conversation

Alok1721
Copy link
Collaborator

@Alok1721 Alok1721 commented Jan 9, 2025 •
edited
Loading

Description

Fixes #(issue number)

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Changes Made

  • Change 1
  • Change 2
  • Change 3

Screenshots (if applicable)

How to Test

  1. Step 1
  2. Step 2
  3. Step 3

Additional Notes

ShmokeD and others added 13 commits December 26, 2024 14:07
@ShmokeD
room and user dp imporovements
fe69ad3
@ShmokeD
Break Reply card into separate widget
7331109
@ShmokeD
add poll data
e6d54a6
@ShmokeD
Add Testing and production branches
14c8276
@ShmokeD
Merge branch 'release24' of https://github.com/zine-robotics/zine_app…
6f0495f 
…_2023 into release24
@ShmokeD
Migration from milliseconds since epoch to DateTime
7b44c64 
Add Polls
Calendar UI update
@ShmokeD
Add Basic File Capabilities
dbed5bb
@ShmokeD
Merge branch 'internal' of https://github.com/zine-robotics/zine_app_…
18588d7 
…2023 into internal
@Alok1721
Merge pull request #35 from ShmokeD/internal
07347f9 
room and user dp imporovements
@Alok1721
some localdb changes and imagePath changes
1464828
@Alok1721
1.poll integrated with localDB 2. NewSchema for Message 3.Database bu…
cdc53e7 
…g fixing
@Alok1721
activeMember update
6b5e8cc
@Alok1721
Merge branch 'release24' into internal
4ced572
zineRobotics
zineRobotics reviewed Jan 9, 2025
View reviewed changes
android/app/build.gradle Outdated
@@ -45,7 +46,7 @@ android {
}

kotlinOptions {
jvmTarget = JavaVersion.VERSION_17
jvmTarget = "1.8"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be jvmTarget = JavaVersion.VERSION_17

rupesh031
rupesh031 reviewed Jan 9, 2025
View reviewed changes
lib/models/events.dart Outdated
description: "A book fair with author signings and discussion panels.",
type: "Education",
name: "Readers' Haven",
venue: "National Library",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never store dummy data like this, it should come from a json file
It should not be pushed to a release branch. Push to release after testing it with api call

@rupesh031 rupesh031 requested review from priyansh210 and DGgrx January 9, 2025 06:07
@rupesh031 rupesh031 self-requested a review January 9, 2025 06:23
priyansh210
priyansh210 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@priyansh210 priyansh210 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving PR , will check the UI changes and functionality on the APP.

@rupesh031
Copy link
Collaborator

image
Unable to send or receive messages, The chat room is empty

Error
Old database Deleted. I/flutter (16809): Error initializing isSynced column: SqliteException(1): while executing, no such column: isSynced, SQL logic error (code 1) I/flutter (16809): Causing statement: UPDATE rooms_table SET isSynced = FALSE, parameters

@Alok1721 NEED This fixed by today evening?

@rupesh031
Copy link
Collaborator

image
@ShmokeD Make this work with Backend data ASAP.

@rupesh031
Copy link
Collaborator

rupesh031 commented Jan 9, 2025 •
edited
Loading

Features needed before we can merge this PR.

  1. Login/Sign-Up (Test with different scenario) - @Alok1721
  2. Chats - Text Messages, Files, Polls (Not Working)- @Alok1721
  3. Timeline for Recruitment with data from backend - (Not Implemented) - @ShmokeD
  4. Events Pages - (Use Data from backend) - @ShmokeD

Focus on functionality, we will work on UI afterwards

Alok1721 and others added 30 commits January 14, 2025 11:03
@Alok1721
erge branch 'alok-working' of https://github.com/zine-robotics/zine_a…
2e1be9c 
…pp_2023 into alok-working

merging alok-working
@Alok1721
1. poll ui-db fix 2.event fetched 3.recruitment added
55762fa
@ShmokeD
fixed missing uploads
10d48d5
@ShmokeD
Merge branch 'alok-working' of https://github.com/zine-robotics/zine_…
abd5540 
…app_2023 into internal
@ShmokeD
Merge from might-work
21478e2
@priyansh210
Merge pull request #43 from ShmokeD/internal
eb27db2 
merge of fixes from alok-working and might-work
@priyansh210
Fixed poll option DB
cb5d118
@rupesh031
working app with last seen and active members
7856707
@rupesh031
fixed ui for images upload
43af01f
@rupesh031
working app with cherry picks
135c3c1
@rupesh031
fixed stuff
33a118c
@priyansh210
Optimized DB calls and File handling
b7c7710
@Alok1721
notification icon added
ec04434
@priyansh210
Internal release
653fb6f
@rupesh031
fixed stuff
0da76ac
@rupesh031
Merge branch 'internal' of https://github.com/DGgrx/zine_app_2023 int…
17ac314 
…o internal
@rupesh031
Working App, Error Handling, Timeouts, TaskFixes, UI Fixes
b13f333
@rupesh031
Deploy For testing
5d6745f
@priyansh210
Poll UI Fixes
d81708a
@rupesh031
Production URL
68fa6f2
@rupesh031
Deploy To Play Store
9805d3d
@Alok1721
some fixes
648154f
@Alok1721
chat ui fixes
027cb69
@priyansh210
download and view media
67c409b
@Alok1721
new projects
88995fa
@Alok1721
file open after downloading
3cbdd7c
@priyansh210
download and view media
6db7df2
@priyansh210
final app for 2025
306f548
@Alok1721
merging internal last commit
ea0453f
@Alok1721
second year added
b451702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zineRobotics zineRobotics zineRobotics left review comments

@priyansh210 priyansh210 priyansh210 approved these changes

@DGgrx DGgrx Awaiting requested review from DGgrx

@rupesh031 rupesh031 Awaiting requested review from rupesh031

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Alok1721 @rupesh031 @priyansh210 @zineRobotics @ShmokeD @MashaalSayeed