Polls #33

ShmokeD · 2025-01-06T12:01:03Z

Add Polls
Calendar UI update## Description

Fixes #(issue number)

Type of Change

Changes Made

Change 1
Change 2
Change 3

Screenshots (if applicable)

How to Test

Step 1
Step 2
Step 3

Additional Notes

…_2023 into release24

Add Polls Calendar UI update

priyansh210 · 2025-01-06T12:10:13Z

Add the changes made as points as mentioned in the PR template
Add screenshots for the UI of the polls
Mention the Edge cases tested/validated for the feature

Alok1721 · 2025-01-06T12:17:37Z

lib/database/database.dart

+}
+
+@DataClassName('FileDB')
+class FileTable extends Table {


what if file message deleted? why not using foreign key?

priyansh210

Fix changes, Also make sure to have smaller PR's next time : making it easier to review.

priyansh210 · 2025-01-06T12:17:17Z

lib/theme/color.dart

+];
+
+Map<String, Color> getDpColours(String name) {


Does this function create a DP with a random background color and name initial for the Users which dont have a dp ?

priyansh210 · 2025-01-06T12:37:48Z

lib/components/profile_picture.dart

+class ProfilePicture extends StatelessWidget {
+  final String dp, name;
+  final double size;
+
+  const ProfilePicture(
+      {super.key, required this.dp, required this.name, this.size = 20});
+
+  @override
+  Widget build(BuildContext context) {
+    Map<String, Color> colours = getDpColours(name);
+    Color backgroundColour = colours['background']!;
+    Color textColour = colours['text']!;
+
+    double width = size * 2.0;
+    return Container(
+      clipBehavior: Clip.hardEdge,
+      constraints: BoxConstraints(
+          minWidth: width, minHeight: width, maxHeight: width, maxWidth: width),
+      decoration: BoxDecoration(
+          borderRadius: BorderRadius.circular(15), color: backgroundColour),
+      child: CachedNetworkImage(
+        imageUrl: dp,
+        fit: BoxFit.cover,
+        errorWidget: (_, __, ___) => Center(
+            child: Text(
+          name.substring(0, 1).toUpperCase(),
+          style: TextStyle(
+              fontWeight: FontWeight.bold, fontSize: size, color: textColour),
+        )),
+      ),
+    );
+  }
+}


We will remove the DP image or default_dp logic from the UI, your build function should ideally:
If : DP is filepath is present -> Fetch the DP from local storage or network
else : Display the text w the background (default DP)
And then build the container.

[Discuss with @Alok1721 ]

priyansh210 · 2025-01-06T12:38:26Z

lib/screens/chat/chat_description/chat_descp.dart

 import 'package:zineapp2023/theme/color.dart';
-import 'package:zineapp2023/screens/chat/chat_screen/chat_room.dart';

 class ChatDescription extends StatelessWidget {


Add in-code doc for the functionality of the class

priyansh210 · 2025-01-06T12:39:51Z

lib/screens/chat/chat_description/chat_descp.dart

    required this.roomName,
    required this.data,
    required this.image,
    super.key,
  });

  final String roomName;
-  final dynamic image;
-  List<ActiveMember> data;
+  final String image;


if this is image_url or file-path make sure the variable name reflets the same intent.

priyansh210 · 2025-01-06T12:43:03Z

lib/screens/chat/chat_screen/components/reply_card.dart

+import 'package:zineapp2023/screens/chat/chat_screen/view_model/chat_room_view_model.dart';
+import 'package:zineapp2023/theme/color.dart';
+
+class ReplyCard extends StatelessWidget {


Add in-code doc for the new class added

priyansh210 · 2025-01-06T12:45:05Z

lib/screens/chat/chat_screen/components/poll_card.dart

+                    Container(
+                        decoration: BoxDecoration(
+                            borderRadius: BorderRadius.circular(10),
+                            border: Border.all(color: Colors.black38)),
+                        padding: const EdgeInsets.only(left: 5, right: 5),
+                        width: double.infinity,
+                        child: Column(children: [
+                          TextField(
+                            controller: _titleController,
+                            decoration: InputDecoration(hintText: "Title"),
+                          ),
+
+                          ..._controllers.map(
+                            (controller) => PollOption(
+                              controller: controller,
+                              onDelete: onDelete,
+                            ),
+                          ),
+
+                          Row(
+                            mainAxisAlignment: MainAxisAlignment.spaceBetween,
+                            children: [
+                              Flexible(
+                                  flex: 9,
+                                  child: IconButton(
+                                      onPressed: () => setState(() {
+                                            _controllers
+                                                .add(TextEditingController());
+                                          }),
+                                      icon: Icon(Icons.add))),
+                              Flexible(
+                                flex: 3,
+                                child: InkWell(
+                                  onTap: () {
+                                    if (kDebugMode) {
+                                      print('inSendPoll');
+                                    }
+                                    chatVm.sendPoll(
+                                        _titleController.text,
+                                        _controllers
+                                            .map(
+                                              (TextEditingController
+                                                      controller) =>
+                                                  controller.text,
+                                            )
+                                            .toList());
+                                  },
+                                  child: SizedBox(
+                                    height: 50,
+                                    child: Center(child: Text('Send Poll')),
+                                  ),
+                                ),
+                              ),
+                            ],
+                          )
+                          // FormField(builder: builder)
+                        ]))
+                  ],
+                ),
+              )),
+          const SizedBox(
+            height: 5,
+          )
+        ],
+      ),
+    );
+  }
+}
+
+class PollOption extends StatelessWidget {
+  final TextEditingController controller;
+  final Function(TextEditingController) onDelete;
+  const PollOption(
+      {super.key, required this.controller, required this.onDelete});
+
+  @override
+  Widget build(BuildContext context) {
+    return Row(
+      children: [
+        Expanded(
+          child: Padding(
+            padding: const EdgeInsets.all(8.0),
+            child: TextFormField(
+              controller: controller,
+              decoration: InputDecoration(hintText: 'Option'),
+            ),
+          ),
+        ),
+        IconButton(
+            onPressed: () {
+              onDelete(controller);
+            },
+            icon: Icon(
+              Icons.cancel,
+              color: greyText,
+            ))
+      ],
+    );
+  }
+}


Are we able to add multiple options in the polls ?

priyansh210 · 2025-01-06T13:03:12Z

lib/screens/onboarding/repo/auth_repo.dart

-      // // print(tasks);
-
-      // Above code just set User's links to empty, if the key wasnt created
-
      UserModel userMod = UserModel(
          uid: uid,
          id: user['id'],
          email: user['email'],
          name: user['name'],
          dp: user['dpUrl'] ?? "1",


rename var to dpUrl if a filePath, applicable everywhere.

ShmokeD added 6 commits December 26, 2024 14:07

room and user dp imporovements

fe69ad3

Break Reply card into separate widget

7331109

add poll data

e6d54a6

Add Testing and production branches

14c8276

Merge branch 'release24' of https://github.com/zine-robotics/zine_app…

6f0495f

…_2023 into release24

Migration from milliseconds since epoch to DateTime

7b44c64

Add Polls Calendar UI update

Alok1721 reviewed Jan 6, 2025

View reviewed changes

priyansh210 requested changes Jan 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Polls #33

Polls #33

ShmokeD commented Jan 6, 2025 •

edited by Alok1721

Loading

priyansh210 commented Jan 6, 2025

Alok1721 Jan 6, 2025

priyansh210 left a comment

priyansh210 Jan 6, 2025

priyansh210 Jan 6, 2025

priyansh210 Jan 6, 2025

priyansh210 Jan 6, 2025

priyansh210 Jan 6, 2025

priyansh210 Jan 6, 2025

priyansh210 Jan 6, 2025

Polls #33

Are you sure you want to change the base?

Polls #33

Conversation

ShmokeD commented Jan 6, 2025 • edited by Alok1721 Loading

Type of Change

Changes Made

Screenshots (if applicable)

How to Test

Additional Notes

priyansh210 commented Jan 6, 2025

Choose a reason for hiding this comment

priyansh210 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShmokeD commented Jan 6, 2025 •

edited by Alok1721

Loading