Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve schema registry support #12

Merged
merged 34 commits into from
Sep 23, 2024
Merged

Conversation

stewartboyd119
Copy link
Member

@stewartboyd119 stewartboyd119 commented Sep 9, 2024

Improve schema registry support

  1. Added formatters which properly use schema registry formatters (zfmt attempted previously, but had missed the mark)
  2. Updated tests to be controlled with envvar instead of build tags
  3. Updated golang-ci to remove deprecated options
  4. Updated make to add proto generation for schema registry evolution tests
  5. Because protobuf has protections against named type collisions, run tests with a special envvar to ignore this warning
  6. Added LifecyclePostReadImmediate for better confirmation of read errors
  7. Updated ReaderOption to not update KWriter directly and instead update an indirect settings object
  8. Updated producer clientId to be clientid + topic this helps avoid accidental collisions seen in production with DLT'd consumer
  9. Updated compose.yml used for local testing to standup schema registry

@codecov-commenter
Copy link

codecov-commenter commented Sep 9, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.08772% with 51 lines in your changes missing coverage. Please review.

Project coverage is 90.57%. Comparing base (c0b0f93) to head (f0923ca).

Files with missing lines Patch % Lines
schemareg.go 70.27% 11 Missing and 11 partials ⚠️
formatter.go 80.76% 5 Missing and 5 partials ⚠️
client.go 89.04% 5 Missing and 3 partials ⚠️
lifecycle.go 80.64% 3 Missing and 3 partials ⚠️
testhelper.go 82.14% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   93.29%   90.57%   -2.72%     
==========================================
  Files          17       18       +1     
  Lines        1283     1539     +256     
==========================================
+ Hits         1197     1394     +197     
- Misses         57       95      +38     
- Partials       29       50      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stewartboyd119 stewartboyd119 changed the title Improve schema registry Improve schema registry support Sep 23, 2024
@stewartboyd119 stewartboyd119 merged commit 0020d7f into main Sep 23, 2024
2 checks passed
@stewartboyd119 stewartboyd119 deleted the improve-schema-registry branch September 23, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants