Update controller-runtime

[SuperQ]

• Update controller runtime to v0.15.3.
• Fixup breaking changes in Validate calls.
• Remove client metric tweak that was removed upstream.
• Bump images in Dockerfiles to match CI.
• Improve upgrade test script.
• Disable metrics in upgrade test.

[SuperQ]

This might fix #249, need to test.

[codecov]

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.84%. Comparing base (95c940a) to head (69e0df6).

Files with missing lines	Patch %	Lines
apis/milvus.io/v1beta1/milvus_webhook.go	77.77%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   76.82%   76.84%   +0.02%     
==========================================
  Files          64       64              
  Lines        6697     6695       -2     
==========================================
  Hits         5145     5145              
+ Misses       1351     1349       -2     
  Partials      201      201              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[SuperQ]

Ugh, I have no idea why the controller upgrade is not doing the right thing here. I guess I'll have to setup a local test setup so I can watch the controller logs.

[sre-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haorenfsa, SuperQ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [haorenfsa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[SuperQ]

I discovered the issue with the controller-runtime upgrade. The kind setup in the CI pipeline does not include the Prometheus Operator. With the previous runtime it seems like the creation failure of the PodMonitor was being ignored. The Milvus would go ready, but had not completely setup the PodMonitor. When the patch was applied, it would never succeed.

Between the two options of installing the Prometheus Operator bundle so the CRDs exist, and simply disabling metrics for this test, I went with disable metrics.

[haorenfsa]

/lgtm