-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Support for Tuya Zemismart 3 Phase Power Meter _TZE200_v9hkz2yn
variant
#3764
base: dev
Are you sure you want to change the base?
Conversation
@TheJulianJES Please merge this PR so that support for this device can be pushed in the next release of ZHA. Thanks |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3764 +/- ##
==========================================
+ Coverage 90.13% 90.19% +0.05%
==========================================
Files 320 320
Lines 10473 10554 +81
==========================================
+ Hits 9440 9519 +79
- Misses 1033 1035 +2 ☔ View full report in Codecov by Sentry. |
@rhakbari Thanks for the PR, we have been putting a lot of effort into transitioning the Tuya codebase to use v2 quirks. I really don't want to see us merge another v1 PR that would need to be updated later on. We don't currently have an example of a v2 power meter quirk merged, but you could look at either #3644 or #3571 to get an idea of where we are headed. Once we merge one of them, you would have a good example to draw from. |
@prairiesnpr Is there some kind of documentation for the quirk v2 library etc that can show some kind of comparison so that I can go through and see what functions i can use from it? |
https://github.com/zigpy/zha-device-handlers/blob/dev/tuya.md and https://github.com/zigpy/zha-device-handlers/wiki/Tuya-%E2%80%90-v2-Quirk-with-TuyaQuirkBuilder would be a good start. |
Proposed change
Added Support for Tuya Zemismart 3 Phase Energy/Power Meter.
The quirk has been personally tested by me.
Link of aliexpress for reference mentioned below:
https://www.aliexpress.us/item/1005006034226090.html?spm=a2g0o.detail.0.0.2d89uoAhuoAhLm&gps-id=pcDetailTopMoreOtherSeller&scm=1007.40050.354490.0&scm_id=1007.40050.354490.0&scm-url=1007.40050.354490.0&pvid=e0a7c7e3-96df-4053-b96d-255e50af4b41&_t=gps-id%3ApcDetailTopMoreOtherSeller%2Cscm-url%3A1007.40050.354490.0%2Cpvid%3Ae0a7c7e3-96df-4053-b96d-255e50af4b41%2Ctpp_buckets%3A668%232846%238107%231934&pdp_npi=4%40dis%21USD%21104.10%2153.09%21%21%21744.61%21379.75%21%402167359c17053892751297392e7755%2112000035421607338%21rec%21US%214539664033%21AB&utparam-url=scene%3ApcDetailTopMoreOtherSeller%7Cquery_from%3A&gatewayAdapt=4itemAdapt
Checklist
pre-commit
checks pass / the code has been formatted using Black