Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Tuya gas sensors to v2, add _TZE200_hr0tdd47 #3635

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

prairiesnpr
Copy link
Contributor

@prairiesnpr prairiesnpr commented Dec 24, 2024

Proposed change

Convert Tuya gas sensors (co) to v2, add _TZE200_hr0tdd47.

Requires a resolution to zigpy/zha#327

Additional information

Fixes: #3632

Based on: https://github.com/Koenkk/zigbee-herdsman-converters/blob/223fad439e83893e0956688c822dda83d46210cf/src/devices/moes.ts#L482

Original quirk exposes just co detected, this adds co concentration, self test result, battery, and silence.

z2m doesn't list _TZE200_ggev5fsl, so not 100% certain that DPs other than co alarm are the same, but it's probable.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.94%. Comparing base (e3d3849) to head (3b58f5f).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3635      +/-   ##
==========================================
+ Coverage   89.85%   89.94%   +0.08%     
==========================================
  Files         322      322              
  Lines       10380    10363      -17     
==========================================
- Hits         9327     9321       -6     
+ Misses       1053     1042      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added Tuya Request/PR regarding a Tuya device v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA. labels Dec 26, 2024
@prairiesnpr prairiesnpr marked this pull request as ready for review December 27, 2024 03:11
@dpozimski
Copy link

can't wait to use it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tuya Request/PR regarding a Tuya device v2 quirk Quirks using v2 API. Might add custom entities that need translation keys in HA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Device Support Request] TS0601 by _TZE200_hr0tdd47
3 participants