Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Support for Tuya Zemismart 3 Phase Power Meter _TZE200_v9hkz2yn variant #3619

Closed
wants to merge 49 commits into from

Conversation

rhakbari
Copy link
Contributor

@rhakbari rhakbari commented Dec 18, 2024

Proposed change

Added Support for Tuya Zemismart 3 Phase Power Meter

Additional information

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@rhakbari rhakbari changed the title Added Support for @rhakbari Added support for Tuya Zemismart 3 Phase Power Meter Dec 18, 2024
@rhakbari rhakbari changed the title @rhakbari Added support for Tuya Zemismart 3 Phase Power Meter Added Support for Tuya Zemismart 3 Phase Power Meter Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 72.83951% with 22 lines in your changes missing coverage. Please review.

Project coverage is 90.19%. Comparing base (4f64c18) to head (fa49d65).

Files with missing lines Patch % Lines
zhaquirks/tuya/ts0601_din_power.py 72.83% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3619      +/-   ##
==========================================
+ Coverage   90.13%   90.19%   +0.05%     
==========================================
  Files         320      320              
  Lines       10473    10554      +81     
==========================================
+ Hits         9440     9519      +79     
- Misses       1033     1035       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rhakbari rhakbari changed the title Added Support for Tuya Zemismart 3 Phase Power Meter Added Support for Tuya Zemismart 3 Phase Power Meter _TZE200_v9hkz2yn variant Dec 18, 2024
@rhakbari
Copy link
Contributor Author

@dmulcahey @TheJulianJES Hi,

I would like this PR to be reviewed and merged so that support for 3 phase power monitor can be added in ZHA. I have personally tested this code locally and its working perfectly.

Thanks.

@TheJulianJES TheJulianJES added the needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state). label Dec 22, 2024
@HobboRobin
Copy link

Hello,

Thats already sounds great. I would love to use this.
I tried it as a costum Quirk but i only get like 25% of the Values. All the others are unknown
image
image

How can we get this one forward ?

@rhakbari
Copy link
Contributor Author

rhakbari commented Jan 6, 2025

Hello,

Thats already sounds great. I would love to use this. I tried it as a costum Quirk but i only get like 25% of the Values. All the others are unknown image image

How can we get this one forward ?

What is the model of your device ? Because I am not getting unknown values for entities. Can you provide the link and picture of the device ?

@HobboRobin
Copy link

@rhakbari rhakbari closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reviewer answer An answer from a reviewer is needed (e.g. why a PR isn't acceptable in the current state).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants