Skip to content

Commit

Permalink
e2e: add no-kubernetes-in-docker label
Browse files Browse the repository at this point in the history
This label means the e2e tests are not suitable to test in
containerized k8s env (kind provider).

In this commit, we label two tests because the large size images
would lead to OOM of cdi-uploader. For more detail, please
refer to:
kubevirt#3577 (comment)

Signed-off-by: howard zhang <[email protected]>
  • Loading branch information
zhlhahaha committed Jan 8, 2025
1 parent 573ce9c commit c5c84af
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/import_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ var _ = Describe("[rfe_id:1115][crit:high][vendor:[email protected]][level:compo
ns = f.Namespace.Name
})

DescribeTable("[test_id:2329] Should fail to import images that require too much space", func(uploadURL string) {
DescribeTable("[test_id:2329] Should fail to import images that require too much space", Label("no-kubernetes-in-docker"), func(uploadURL string) {
imageURL := fmt.Sprintf(uploadURL, f.CdiInstallNs)

By(imageURL)
Expand Down
2 changes: 1 addition & 1 deletion tests/upload_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ var _ = Describe("[rfe_id:138][crit:high][vendor:[email protected]][level:compon
Entry("fail given a large physical size QCOW2 file", utils.UploadFileLargePhysicalDiskQcow),
)

DescribeTable("[posneg:negative][test_id:2330]Verify failure on sync upload if virtual size > pvc size", Serial, func(filename string) {
DescribeTable("[posneg:negative][test_id:2330]Verify failure on sync upload if virtual size > pvc size", Label("no-kubernetes-in-docker"), Serial, func(filename string) {
By("Verify PVC annotation says ready")
found, err := utils.WaitPVCPodStatusReady(f.K8sClient, pvc)
Expect(err).ToNot(HaveOccurred())
Expand Down

0 comments on commit c5c84af

Please sign in to comment.