ZUIEditor tools: Ordered list, bullet list, bold and italic
#2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziggabyte
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
I'm approving, but if the "Foo button" text was not intentionally left for later, it needs internationalisation i think.
Also thought about this when i played with it, that I'm not enjoying that the toolbar is open already when i go to the tab. Arriving in this state does not feel smooth to me. Also not for this pr to solve, but noticed it now so writing it now.
| const { dispatch, state, tr } = props; | ||
| const newNode = this.type.create( | ||
| null, | ||
| this.type.schema.text('Foo button') |
There was a problem hiding this comment.
I'm assuming this is either left in here accidentally, or intentionally left to be internationalised at a later point?
| const blockExtensions: ZetkinExtension[] = []; | ||
| const otherExtensions: Extension[] = []; | ||
| const otherExtensions: AnyExtension[] = []; | ||
| const blockExtensions: BlockExtension[] = []; | ||
|
|
||
| if (enableButton) { |
There was a problem hiding this comment.
I can't say I like this very long list of "if this - add that" but maybe it is inevitable. Also not to be fixed in this pr, just a thought for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates four builtin remirror extensions into the editor, and introduces the link extension into the same patterns as all other tools.
Screenshots
Changes
Notes to reviewer
None
Related issues
Undocumented