New bulk ops in importer #2472
Draft
New bulk ops in importer #2472
+662
−1,293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziggabyte
approved these changes
Jan 30, 2025
| @@ -3,7 +3,7 @@ import { useAppDispatch } from 'core/hooks'; | |||
| import { CellData, Column, ColumnKind } from '../utils/types'; | |||
|
|
|||
| export const genders = ['f', 'm', 'o'] as const; | |||
| export type Gender = typeof genders[keyof typeof genders]; | |||
There was a problem hiding this comment.
love that "length" was a valid gender in the Zetkin Universe for some time, without anyone noticing 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
prepareImportOperations()to replace theperson.importbulk operation with new ops being added to the backend in the near future, that separates the actions into separate ops:person.getto find an existing person by ID (or create if it's missing)person.createto create a person object when no ID existsperson.setfieldsto set fields on an existing or new person objectperson.tagto tag an existing or new person objectperson.addtoorgto add an existing or new person object to an organizationIn doing so, it also replaces the test suite for
prepareImportOperations()to be a little bit more lean.Screenshots
None
Changes
prepareImportOperations()to use new opsprepareImportOperations()test suiteGendertypeNotes to reviewer
None
Related issues
Undocumented