ci: require all tests passing in CI

zeromq · Dec 30, 2024 · 905b4ae · 905b4ae
1 parent d69baf8
commit 905b4ae
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -155,13 +155,8 @@ jobs:
 
       - name: Test
         if: ${{ !matrix.dockerfile }}
-        uses: nick-fields/retry@v3
-        with:
-          timeout_minutes: 5
-          max_attempts: 1
-          command: |
-            pnpm run test.unit
-        continue-on-error: true
+        run: |
+          pnpm run test.unit
 
       - name: Clean Tmp
         run: rm -rf ./tmp

diff --git a/package.json b/package.json
@@ -109,7 +109,7 @@
     "test.unit.debug": "run-s clean.temp build.debug && mocha ./test/unit/*-test.ts",
     "test.unit.compat": "run-s clean.temp build && cross-env INCLUDE_COMPAT_TESTS=true mocha ./test/unit/compat/*-test.ts",
     "test.unit.nogc": "run-s clean.temp build && cross-env SKIP_GC_TESTS=true mocha",
-    "test.electron.main": "run-s clean.temp build && electron-mocha ./test/unit/*-test.ts",
+    "test.electron.main": "run-s clean.temp build && cross-env SKIP_GC_TESTS=true electron-mocha ./test/unit/*-test.ts",
     "test.electron.renderer": "run-s build && electron-mocha --renderer ./test/unit/*-test.ts",
     "test.smoke": "bash ./script/smoke-test.bash",
     "format": "run-s format.prettier format.clang-format",

diff --git a/test/unit/typings-compatibility-test.ts b/test/unit/typings-compatibility-test.ts
@@ -129,7 +129,11 @@ describe("compatibility of typings for typescript versions", async function () {
     })
 
     afterEach(async () => {
-      await remove(tscTargetPath)
+      try {
+        await remove(tscTargetPath)
+      } catch (err) {
+        console.error(`Failed to remove ${tscTargetPath}:`, err)
+      }
     })
   }
 })