Fix for PHP 7.3 #190
Closed
Fix for PHP 7.3 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remicollet
commented
Jun 27, 2018
| GC_REFCOUNT(&le) = 1; | ||
| #else | ||
| GC_SET_REFCOUNT(&le, 1); | ||
| #endif |
There was a problem hiding this comment.
From UPGRADING.INTERNALS
f. GC_REFCOUNT() is turned into inline function and can't be modified direcly.
All reference-counting operations should be done through corresponding
macros GC_SET_REFCOUNT(), GC_ADDREF() and GC_DELREF().
GC_REFCOUNT(p)++ should be changed into GC_ADDREF(p),
GC_REFCOUNT(p)-- into GC_DELREF(p),
GC_REFCOUNT(p) = 1 into GC_SET_REFCOUNT(p, 1).
remicollet
commented
Jun 27, 2018
| @@ -63,7 +63,7 @@ char *php_zmq_printable_func (zend_fcall_info *fci, zend_fcall_info_cache *fci_c | |||
| char *buffer = NULL; | |||
|
|
|||
| if (fci->object) { | |||
| spprintf (&buffer, 0, "%s::%s", fci->object->ce->name->val, fci_cache->function_handler->common.function_name); | |||
| spprintf (&buffer, 0, "%s::%s", fci->object->ce->name->val, ZSTR_VAL(fci_cache->function_handler->common.function_name)); | |||
There was a problem hiding this comment.
this is a zend_string since 7.0.
PHP 7.3 now nicely raise -Wformat warning about this
remicollet
commented
Jun 27, 2018
| @@ -169,7 +169,7 @@ static | |||
| zend_string *s_create_key(zval *entry) | |||
| { | |||
| if (Z_TYPE_P(entry) == IS_RESOURCE) { | |||
| return strpprintf(0, "r:%ld", Z_RES_P(entry)->handle); | |||
| return strpprintf(0, "r:%d", Z_RES_P(entry)->handle); | |||
There was a problem hiding this comment.
-Wformat again, hadle is an int
remicollet
commented
Jun 27, 2018
| @@ -222,7 +222,7 @@ size_t php_zmq_pollset_num_items(php_zmq_pollset *set) | |||
| zend_string *php_zmq_pollset_add(php_zmq_pollset *set, zval *entry, int events, int *error) | |||
| { | |||
| zend_string *key; | |||
| size_t num_items, index; | |||
| size_t index; | |||
There was a problem hiding this comment.
-Wunused-but-set-variable
|
Notice: this only fix the build, there is something wrong, test suite segfault in various test... |
|
Is there some updates regarding this PR? The currently packaged version in Debian of PHP is 7.3 and it's not working anymore with the php-zmq package. |
|
I applied your patch and tried with Movim, still having a |
|
pr #193 is better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.