gpio: shell: fix a crash where there's less line names than gpios #85890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move SHELL_DYNAMIC_CMD_CREATE after the function, then the forward declaration is unnecessary. Signed-off-by: Fabio Baltieri <[email protected]>
line_cmp is only used in this file, make it static. Signed-off-by: Fabio Baltieri <[email protected]>
Don't try to dereference line_names if the index is beyond line_names_len, this can happen if there's less line names than the total amount of supported gpios specified. Signed-off-by: Fabio Baltieri <[email protected]>
henrikbrixandersen
approved these changes
Feb 17, 2025
kartben
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a potential gpio shell command crash, sneak in two other cleanups too.