-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: Controller: Default to BT_CTLR_SCAN_AUX_USE_CHAINS #85717
base: main
Are you sure you want to change the base?
Bluetooth: Controller: Default to BT_CTLR_SCAN_AUX_USE_CHAINS #85717
Conversation
bca3c2f
to
bb3a298
Compare
BT_CTLR_SCAN_AUX_USE_CHAINS is alternative new design with less RAM usage for supporting Extended Scanning of simultaneous interleaved Extended Advertising chains. Switch Extended Scanning to default to BT_CTLR_SCAN_AUX_USE_CHAINS design in the Controller. Deprecate use of BT_CTLR_SCAN_AUX_SET. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
bb3a298
to
290d098
Compare
What was the issue with the previous one? That seemed much simpler :) |
I got the deprecated warning for non-extended scanning samples (with bb3a298)
|
@Tronil there has been a failure switching the extended scanning design for Periodic Sync to chian PDUs, does this ring a bell? or this is some regression I have introduced in the Nordic LLL lll_sync.c file? Failing test in BSIM CI is: tests/bsim/bluetooth/host/adv/periodic/tests_scripts/per_adv_long_data.sh |
That does not ring a bell, unfortunately. Though reception of chained periodic advertisements is one of the things that are less tested since we do not have the buffer space for it on our HW (meaning we only support the minimum required 251 bytes of advertising data - which can in theory involve chaining, but is unlikely to). |
There is also an assertion that has surfaced during overnight testing of observer role:
|
BT_CTLR_SCAN_AUX_USE_CHAINS is alternative new design with less RAM usage for supporting Extended Scanning of simultaneous interleaved Extended Advertising chains.
Switch Extended Scanning to default to
BT_CTLR_SCAN_AUX_USE_CHAINS design in the Controller.
Deprecate use of BT_CTLR_SCAN_AUX_SET.
Fixes #85209.