Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: Controller: Default to BT_CTLR_SCAN_AUX_USE_CHAINS #85717

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cvinayak
Copy link
Contributor

@cvinayak cvinayak commented Feb 13, 2025

BT_CTLR_SCAN_AUX_USE_CHAINS is alternative new design with less RAM usage for supporting Extended Scanning of simultaneous interleaved Extended Advertising chains.

Switch Extended Scanning to default to
BT_CTLR_SCAN_AUX_USE_CHAINS design in the Controller.

Deprecate use of BT_CTLR_SCAN_AUX_SET.

Fixes #85209.

Thalley
Thalley previously approved these changes Feb 13, 2025
jhedberg
jhedberg previously approved these changes Feb 13, 2025
BT_CTLR_SCAN_AUX_USE_CHAINS is alternative new design with
less RAM usage for supporting Extended Scanning of
simultaneous interleaved Extended Advertising chains.

Switch Extended Scanning to default to
BT_CTLR_SCAN_AUX_USE_CHAINS design in the Controller.

Deprecate use of BT_CTLR_SCAN_AUX_SET.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
@cvinayak cvinayak dismissed stale reviews from jhedberg and Thalley via 290d098 February 13, 2025 10:57
@cvinayak cvinayak force-pushed the github_scan_aux_use_chains_default branch from bb3a298 to 290d098 Compare February 13, 2025 10:57
@Thalley
Copy link
Collaborator

Thalley commented Feb 13, 2025

@jhedberg @Thalley had to fix the depends on https://github.com/zephyrproject-rtos/zephyr/compare/bb3a29819e2af826b58d1b6c9854011ff769182e..290d0988d22a5590f666d6687697295e8fb53b13

What was the issue with the previous one? That seemed much simpler :)

@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 13, 2025

@jhedberg @Thalley had to fix the depends on https://github.com/zephyrproject-rtos/zephyr/compare/bb3a29819e2af826b58d1b6c9854011ff769182e..290d0988d22a5590f666d6687697295e8fb53b13

What was the issue with the previous one? That seemed much simpler :)

I got the deprecated warning for non-extended scanning samples (with bb3a298)

$ cmake -GNinja -DBOARD=nrf54l15dk/nrf54l15/cpuapp ../../samples/bluetooth/peripheral_hr
Loading Zephyr default modules (Zephyr base).
-- Application: /home/jack/workspace/zephyrproject/zephyr/samples/bluetooth/peripheral_hr
-- CMake version: 3.30.4
-- Found Python3: /home/jack/workspace/python/bin/python (found suitable version "3.12.7", minimum required is "3.10") found components: Interpreter
-- Cache files will be written to: /home/jack/.cache/zephyr
-- Zephyr version: 4.0.99 (/home/jack/workspace/zephyrproject/zephyr)
-- Found west (found suitable version "1.2.0", minimum required is "0.14.0")
-- Board: nrf54l15dk, qualifiers: nrf54l15/cpuapp
-- ZEPHYR_TOOLCHAIN_VARIANT not set, trying to locate Zephyr SDK
-- Found host-tools: zephyr 0.16.5 (/home/jack/.local/zephyr-sdk-0.16.5-1)
-- Found toolchain: zephyr 0.16.5 (/home/jack/.local/zephyr-sdk-0.16.5-1)
-- Found Dtc: /home/jack/.local/zephyr-sdk-0.16.5-1/sysroots/x86_64-pokysdk-linux/usr/bin/dtc (found suitable version "1.6.0", minimum required is "1.4.6")
-- Found BOARD.dts: /home/jack/workspace/zephyrproject/zephyr/boards/nordic/nrf54l15dk/nrf54l15dk_nrf54l15_cpuapp.dts
-- Generated zephyr.dts: /home/jack/workspace/zephyrproject/zephyr/build/peripheral_hr/zephyr/zephyr.dts
-- Generated pickled edt: /home/jack/workspace/zephyrproject/zephyr/build/peripheral_hr/zephyr/edt.pickle
-- Generated devicetree_generated.h: /home/jack/workspace/zephyrproject/zephyr/build/peripheral_hr/zephyr/include/generated/zephyr/devicetree_generated.h
-- Including generated dts.cmake file: /home/jack/workspace/zephyrproject/zephyr/build/peripheral_hr/zephyr/dts.cmake

warning: Deprecated symbol BT_CTLR_SCAN_AUX_SET_DEPRECATED is enabled.

Parsing /home/jack/workspace/zephyrproject/zephyr/Kconfig
Loaded configuration '/home/jack/workspace/zephyrproject/zephyr/boards/nordic/nrf54l15dk/nrf54l15dk_nrf54l15_cpuapp_defconfig'
Merged configuration '/home/jack/workspace/zephyrproject/zephyr/samples/bluetooth/peripheral_hr/prj.conf'
Configuration saved to '/home/jack/workspace/zephyrproject/zephyr/build/peripheral_hr/zephyr/.config'
Kconfig header saved to '/home/jack/workspace/zephyrproject/zephyr/build/peripheral_hr/zephyr/include/generated/zephyr/autoconf.h'
-- Found GnuLd: /home/jack/.local/zephyr-sdk-0.16.5-1/arm-zephyr-eabi/arm-zephyr-eabi/bin/ld.bfd (found version "2.38")
-- The C compiler identification is GNU 12.2.0
-- The CXX compiler identification is GNU 12.2.0
-- The ASM compiler identification is GNU
-- Found assembler: /home/jack/.local/zephyr-sdk-0.16.5-1/arm-zephyr-eabi/bin/arm-zephyr-eabi-gcc
-- Using ccache: /usr/bin/ccache
-- Configuring done (8.5s)
-- Generating done (0.2s)
-- Build files have been written to: /home/jack/workspace/zephyrproject/zephyr/build/peripheral_hr

@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 13, 2025

@Tronil there has been a failure switching the extended scanning design for Periodic Sync to chian PDUs, does this ring a bell? or this is some regression I have introduced in the Nordic LLL lll_sync.c file? Failing test in BSIM CI is: tests/bsim/bluetooth/host/adv/periodic/tests_scripts/per_adv_long_data.sh

@Tronil
Copy link
Contributor

Tronil commented Feb 13, 2025

@Tronil there has been a failure switching the extended scanning design for Periodic Sync to chian PDUs, does this ring a bell? or this is some regression I have introduced in the Nordic LLL lll_sync.c file? Failing test in BSIM CI is: tests/bsim/bluetooth/host/adv/periodic/tests_scripts/per_adv_long_data.sh

That does not ring a bell, unfortunately. Though reception of chained periodic advertisements is one of the things that are less tested since we do not have the buffer space for it on our HW (meaning we only support the minimum required 251 bytes of advertising data - which can in theory involve chaining, but is unlikely to).

@cvinayak cvinayak modified the milestones: v4.1.0, v4.2.0 Feb 14, 2025
@cvinayak
Copy link
Contributor Author

There is also an assertion that has surfaced during overnight testing of observer role:

[2025-02-13 21:33:50.381] 1142877. [DEVICE]: 16:3B:6D:A3:83:51 (random), AD evt type 5, Tx Pwr: 127, RSSI -41 Data stASSERTION FAIL [(ticker_status == 0) || (ticker_status == 2)] @ WEST_TOPDIR/zephyr/subsys/bluetooth/controller/ll_sw/ull_scan_aux.c:2810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Review
Development

Successfully merging this pull request may close these issues.

Bluetooth: Controller: Switch Extended Scanning to default to BT_CTLR_SCAN_AUX_USE_CHAINS
6 participants