drivers: video: video_common: refactor video_closest_frmival_stepwise() #85697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josuah
force-pushed
the
pr-fix-video-common
branch
from
2f1c32e to
e62d581
Compare
josuah
force-pushed
the
pr-fix-video-common
branch
from
e62d581 to
7f723af
Compare
drivers/video/video_common.c
Outdated
|
|
||
| /* Loose precision until landing within 32-bit range */ | ||
| while (numerator_min > UINT32_MAX || numerator_step > UINT32_MAX || | ||
| denominator >UINT32_MAX) { |
There was a problem hiding this comment.
^^ missing space, see the compliance check
There was a problem hiding this comment.
You are right... Should be fixed now!
Avoid an integer overflow by dividing the numerator and denominator by two (dropping one bit of precision), which preserve the ratio. Result still accurate, as only done on values larger than UINT32_MAX. fixes CID-444385, CID-444388 and CID-444389 Signed-off-by: Josuah Demangeon <[email protected]>
josuah
force-pushed
the
pr-fix-video-common
branch
from
7f723af to
eaee9f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid an integer overflow by reducing the precision until the result is checked to fit in 32-bit. This is possible by simplifying fractions by 2, which should not affect the result significantly as this is only done when the values are extremely large (too large to fit 32-bit int).
Also adding a test case that would overflow without proper handling.
Fixes: