-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: drivers: uart: add 54l15 fast uart #85622
base: main
Are you sure you want to change the base?
Conversation
1ac2031
to
6bdb0ae
Compare
6d92851
6bdb0ae
to
6d92851
Compare
6d92851
to
dad4b90
Compare
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
dad4b90
to
5a69cd3
Compare
/ { | ||
soc { | ||
peripheral@50000000 { | ||
/delete-node/ spi@4a000; | ||
}; | ||
}; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this target (real HW) is build without it I get a cmake error about duplicate unit-address
/soc/peripheral@50000000/spi@4a000
/soc/peripheral@50000000/uart@4a000
Simple disabling spi00 node via status will cause "parse error: undefined node label 'spi00'" due to
this deletion in case of bsim target
Basically this is to make both cases work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple disabling spi00 node via status will cause "parse error: undefined node label 'spi00'" due to this deletion in case of bsim target
This is a peculiarity of the bsim target then and should be addressed in its overlay (it looks like that overlay should not just include nrf54l15dk_nrf54l15_cpuapp.overlay
). And here, spi00
should be just disabled.
5a69cd3
to
5a94794
Compare
A test is going to use this UART also, so we'll need it. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Add the fast uart instance of 54l15 for testing Signed-off-by: Piotr Krzyzanowski <[email protected]>
Disable insted of deletion of spi00 node on 54l15bsim Signed-off-by: Piotr Krzyzanowski <[email protected]>
5a94794
to
adc1047
Compare
Add the fast uart instance of 54l15 for testing