Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: drivers: uart: add 54l15 fast uart #85622

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nordic-pikr
Copy link
Contributor

@nordic-pikr nordic-pikr commented Feb 11, 2025

Add the fast uart instance of 54l15 for testing

@zephyrbot zephyrbot added the area: UART Universal Asynchronous Receiver-Transmitter label Feb 11, 2025
@zephyrbot zephyrbot requested a review from dcpleung February 11, 2025 16:12
dcpleung
dcpleung previously approved these changes Feb 11, 2025
masz-nordic
masz-nordic previously approved these changes Feb 12, 2025
@nordic-pikr nordic-pikr dismissed stale reviews from masz-nordic and dcpleung via 6d92851 February 12, 2025 13:05
@nordic-pikr nordic-pikr marked this pull request as draft February 12, 2025 13:12
@zephyrbot
Copy link
Collaborator

zephyrbot commented Feb 13, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@nordic-pikr nordic-pikr marked this pull request as ready for review February 13, 2025 12:01
@zephyrbot zephyrbot added the platform: nRF BSIM Nordic Semiconductors, nRF BabbleSim label Feb 13, 2025
@zephyrbot zephyrbot requested a review from aescolar February 13, 2025 12:01
@nordic-pikr nordic-pikr requested a review from dcpleung February 13, 2025 12:03
aescolar
aescolar previously approved these changes Feb 13, 2025
Comment on lines 3 to 5
/ {
soc {
peripheral@50000000 {
/delete-node/ spi@4a000;
};
};
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this target (real HW) is build without it I get a cmake error about duplicate unit-address
/soc/peripheral@50000000/spi@4a000
/soc/peripheral@50000000/uart@4a000

Simple disabling spi00 node via status will cause "parse error: undefined node label 'spi00'" due to
this deletion in case of bsim target

Basically this is to make both cases work

Copy link
Member

@anangl anangl Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple disabling spi00 node via status will cause "parse error: undefined node label 'spi00'" due to this deletion in case of bsim target

This is a peculiarity of the bsim target then and should be addressed in its overlay (it looks like that overlay should not just include nrf54l15dk_nrf54l15_cpuapp.overlay). And here, spi00 should be just disabled.

aescolar
aescolar previously approved these changes Feb 14, 2025
anangl
anangl previously approved these changes Feb 14, 2025
aescolar and others added 3 commits February 14, 2025 14:00
A test is going to use this UART also, so we'll need it.

Signed-off-by: Alberto Escolar Piedras <[email protected]>
Add the fast uart instance of 54l15 for testing

Signed-off-by: Piotr Krzyzanowski <[email protected]>
Disable insted of deletion of spi00 node on 54l15bsim

Signed-off-by: Piotr Krzyzanowski <[email protected]>
@fabiobaltieri fabiobaltieri assigned anangl and unassigned dcpleung Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UART Universal Asynchronous Receiver-Transmitter platform: nRF BSIM Nordic Semiconductors, nRF BabbleSim
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants