Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

espressif: add console and RTC kconfig entries #85293

Merged

Conversation

sylvioalves
Copy link
Collaborator

@sylvioalves sylvioalves commented Feb 6, 2025

Add hidden console and RTC configurations used in hal
to common SoC folder.

Fixes #85290.

@zephyrbot zephyrbot added the platform: ESP32 Espressif ESP32 label Feb 6, 2025
@sylvioalves sylvioalves force-pushed the bugfix/console_compliance branch 2 times, most recently from 0fad445 to 719a9e7 Compare February 6, 2025 11:33
@sylvioalves sylvioalves changed the title espressif: add console kconfig entries espressif: add console and RTC kconfig entries Feb 6, 2025
ydamigos
ydamigos previously approved these changes Feb 6, 2025
Copy link
Collaborator

@ydamigos ydamigos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Issue fixed.

@sylvioalves
Copy link
Collaborator Author

Oh, wait, I need to update hal as well.

@sylvioalves sylvioalves added the DNM This PR should not be merged (Do Not Merge) label Feb 6, 2025
@wmrsouza
Copy link
Collaborator

wmrsouza commented Feb 6, 2025

LGTM

marekmatej
marekmatej previously approved these changes Feb 6, 2025
@sylvioalves sylvioalves dismissed stale reviews from marekmatej and ydamigos via cf336b6 February 6, 2025 17:42
@sylvioalves sylvioalves force-pushed the bugfix/console_compliance branch from 719a9e7 to cf336b6 Compare February 6, 2025 17:42
@sylvioalves sylvioalves removed the DNM This PR should not be merged (Do Not Merge) label Feb 6, 2025
@sylvioalves
Copy link
Collaborator Author

Added necessary hal update.

@zephyrbot
Copy link
Collaborator

zephyrbot commented Feb 6, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_espressif zephyrproject-rtos/hal_espressif@2b81987 zephyrproject-rtos/hal_espressif@07526d5 zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

marekmatej
marekmatej previously approved these changes Feb 6, 2025
ydamigos
ydamigos previously approved these changes Feb 7, 2025
wmrsouza
wmrsouza previously approved these changes Feb 7, 2025
@sylvioalves sylvioalves dismissed stale reviews from wmrsouza and ydamigos via 99fc154 February 10, 2025 13:22
@sylvioalves
Copy link
Collaborator Author

Removed CONFIG_ESP_CONSOLE_UART_NONE as it was not used.

marekmatej
marekmatej previously approved these changes Feb 10, 2025
wmrsouza
wmrsouza previously approved these changes Feb 10, 2025
@sylvioalves sylvioalves requested a review from ydamigos February 10, 2025 13:37
Add hidden console and RTC configurations used in hal
to common SoC folder.

Signed-off-by: Sylvio Alves <[email protected]>
@kartben kartben merged commit a0bdafb into zephyrproject-rtos:main Feb 10, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check_compliance.py: Running Kconfig module fails when hal_espressif is not present
7 participants