drivers: adc: iadc_gecko: Use pinctrl and clock control, add bindings #84508
+231
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Pinctrl
platform: Silabs
jhedberg
reviewed
Jan 24, 2025
asmellby
force-pushed
the
feature/series2-iadc-improvements
branch
from
a7542ca to
15f82f5
Compare
drivers/adc/iadc_gecko.c
Outdated
There was a problem hiding this comment.
Since this driver is only compatible with SiSDK/Series-2, I suggest to drop "gecko" from its name.
asmellby
force-pushed
the
feature/series2-iadc-improvements
branch
from
15f82f5 to
a03fc42
Compare
jerome-pouiller
previously approved these changes
Jan 30, 2025
asmellby
force-pushed
the
feature/series2-iadc-improvements
branch
from
a03fc42 to
87cbe14
Compare
jhedberg
previously approved these changes
Jan 31, 2025
Martinhoff-maker
approved these changes
Feb 3, 2025
anangl
previously approved these changes
Feb 3, 2025
|
@asmellby this has some merge conflicts |
Make use of ABUS support in the pinctrl driver to allocate analog buses, rather than hard-coding bus 0 in the ADC driver. Signed-off-by: Aksel Skauge Mellbye <[email protected]>
Use clock control driver instead of hard-coding HAL function calls to configure clocks. Signed-off-by: Aksel Skauge Mellbye <[email protected]>
Add macros for use in devicetree to configure IADC on Silabs Series 2 devices. Signed-off-by: Aksel Skauge Mellbye <[email protected]>
Add overlays for xg24_dk2601b and xg27_dk2602a for the accuracy test. Update the api test to use named macros for readability. Signed-off-by: Aksel Skauge Mellbye <[email protected]>
Add support for xg24_rb4187c to the ADC sample app. Configure two channels, one measuring the AVDD supply against the 1.21V bandgap reference, and one measuring pin PB1 (wired to button 0) against the AVDD (VDDX) reference. Signed-off-by: Aksel Skauge Mellbye <[email protected]>
asmellby
dismissed stale reviews from anangl, jhedberg, and jerome-pouiller
via
0c7ddfe
asmellby
force-pushed
the
feature/series2-iadc-improvements
branch
from
87cbe14 to
0c7ddfe
Compare
jhedberg
approved these changes
Feb 3, 2025
anangl
approved these changes
Feb 3, 2025
jerome-pouiller
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pinctrl for ABUS allocation (leveraging #84462), use clock control to enable peripheral clock. Add headers with utility macros for easier configuration of IADC inputs. Enable accuracy test, update api test to use bindings header.