drivers: sdhc: Add MAX32 SDHC driver #83464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mertekren
force-pushed
the
add-max32-sdhc
branch
from
9d6a657 to
d0b3a61
Compare
mertekren
changed the title
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_adi
DNM
mertekren
force-pushed
the
add-max32-sdhc
branch
from
137184f to
e474287
Compare
zephyrbot
added
area: Disk Access
platform: ADI
zephyrbot
requested review from
danieldegrasse,
de-nordic,
decsny,
galak,
jfischer-no,
kartben,
Laczen,
MaureenHelm,
microbuilder,
nashif,
ozersa and
ttmut
| * remove this with a better solution in future. | ||
| */ | ||
| k_sleep(K_MSEC(1)); | ||
| ret = MXC_SDHC_SendCommand(&sd_cmd_cfg); |
There was a problem hiding this comment.
Question here- is this function blocking? Or does it use interrupts within the HAL layer?
There was a problem hiding this comment.
yes it's blocking. it loops in while() until register is complete/timeout. we'll try to add interrupt functionality in future.
mertekren
force-pushed
the
add-max32-sdhc
branch
from
167ff00 to
5281727
Compare
MaureenHelm
reviewed
Jan 20, 2025
samples/subsys/fs/fs_sample/boards/max32666fthr_max32666_cpu0.overlay
Outdated
Show resolved
Hide resolved
tests/drivers/disk/disk_performance/boards/max32666fthr_max32666_cpu0.overlay
Outdated
Show resolved
Hide resolved
mertekren
force-pushed
the
add-max32-sdhc
branch
from
5281727 to
3360ad1
Compare
yes i rebased wrong, should be good now. thanks! :) |
mertekren
force-pushed
the
add-max32-sdhc
branch
from
f846402 to
e890027
Compare
mertekren
force-pushed
the
add-max32-sdhc
branch
2 times, most recently
from
96adc08 to
005d7c2
Compare
mertekren
force-pushed
the
add-max32-sdhc
branch
from
005d7c2 to
a58c185
Compare
MaureenHelm
reviewed
Feb 4, 2025
fabiobaltieri
added
DNM (manifest)
mertekren
force-pushed
the
add-max32-sdhc
branch
from
a58c185 to
7536b2d
Compare
zephyrbot
removed
the
DNM (manifest)
MaureenHelm
previously approved these changes
Feb 4, 2025
|
Needs rebase. @danieldegrasse can you take another look? |
Include sdhc0 in MAX32666 devicetree and add devicetree bindings for MAX32 SDHC driver Signed-off-by: Mert Ekren <[email protected]>
This commit adds MAX32666 SDHC driver. Co-Authored-By: Anil Kara <[email protected]> Co-Authored-By: Tahsin Mutlugun <[email protected]> Signed-off-by: Mert Ekren <[email protected]>
Add SDHC to supported list for MAX32666FTHR Signed-off-by: Mert Ekren <[email protected]>
Add MAX32666fthr for fs_sample testing Signed-off-by: Mert Ekren <[email protected]>
Add MAX32666fthr sdhc to tests/drivers/disk/disk_performance Signed-off-by: Mert Ekren <[email protected]>
mertekren
force-pushed
the
add-max32-sdhc
branch
from
3d20e52 to
c970981
Compare
| if (ios->power_mode == SDHC_POWER_OFF) { | ||
| MXC_SDHC_PowerDown(); | ||
| } else { | ||
| MXC_SDHC_PowerUp(); |
There was a problem hiding this comment.
Is this function a no-op if the card is already powered up? If so, I think this is fine- just want to make sure
| .get_card_present = sdhc_max32_get_card_present, | ||
| .card_busy = sdhc_max32_card_busy, | ||
| .get_host_props = sdhc_max32_get_host_props, | ||
| .enable_interrupt = NULL, |
There was a problem hiding this comment.
Nit- these will be null if simply left out of initializer
danieldegrasse
approved these changes
Feb 14, 2025
MaureenHelm
approved these changes
Feb 14, 2025
|
@MaureenHelm just in time! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SDHC support for max32666fthr.
Implement SDHC driver for MAX32666fthr
Add sdhc0 instances for MAX32666 .dtsi file
Add SDHC to MAX32666fthr board driver list
tests:
.\tests\drivers\sdhc
.\samples\subsys\fs\fs_sample\
.\tests\drivers\disk\disk_performance
Dependencies: