Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ieee802154 and entropy mcux driver and necessary changes #83195

Merged
merged 8 commits into from
Feb 14, 2025
Merged

add ieee802154 and entropy mcux driver and necessary changes #83195

merged 8 commits into from
Feb 14, 2025

Conversation

andrei-menzopol
Copy link
Contributor

@andrei-menzopol andrei-menzopol commented Dec 19, 2024 •
edited
Loading

Description

drivers: entropy: add mcxw trng
drivers: ieee802154: add mcxw ieee802154 driver
dts: nxp: add ieee and trng bindings and nodes
soc: nxp: mcxw: update conditions to account for ieee driver
samples: echo_client echo_server: add frdm_mcxw7 board overlays
samples: echo_client echo_server: update tests
doc: frdm_mcxw71: update documentation
modules: hal_nxp: update commit to PR 491

Testing

  • Compiled echo_server/echo_client with: west build -p always -b frdm_mcxw71 samples/net/sockets/echo_client -- -DEXTRA_CONF_FILE=overlay-ot.conf
  • Created a thread network with it and joined another thread device
  • Checked that the thread communication is working (with a 15.4 thread wireshark capture)
  • Was able to see the neighbors and ping

@github-actions GitHub Actions
Copy link

Hello @andrei-menzopol, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@zephyrbot
Copy link
Collaborator

zephyrbot commented Dec 19, 2024 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@5e1979c zephyrproject-rtos/hal_nxp@605560a (master) zephyrproject-rtos/[email protected]

Additional metadata changed:

Name URL Submodules West cmds module.yml
hal_nxp ✏

⛔ DNM label due to: 1 project with metadata changes

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@George-Stefan George-Stefan mentioned this pull request Dec 19, 2024
Merged
@George-Stefan
Copy link
Collaborator

#82803

@George-Stefan George-Stefan mentioned this pull request Dec 19, 2024
Closed
axelnxp
axelnxp suggested changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@axelnxp axelnxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's still a draft, but suggesting some changes for the final version

drivers/ieee802154/Kconfig.mcxw Show resolved Hide resolved
drivers/ieee802154/Kconfig.mcxw Outdated Show resolved Hide resolved
west.yml Outdated Show resolved Hide resolved
@zephyrbot zephyrbot added the DNM This PR should not be merged (Do Not Merge) label Feb 3, 2025
@andrei-menzopol andrei-menzopol changed the title add ieee802154 mcux driver add ieee802154 mcux driver and necessary changes Feb 3, 2025
@andrei-menzopol andrei-menzopol force-pushed the mcxw-ieee-driver branch 4 times, most recently from cf00941 to ed419dc Compare February 4, 2025 12:48
@andrei-menzopol andrei-menzopol marked this pull request as ready for review February 4, 2025 12:48
@zephyrbot zephyrbot requested review from ankuns and ceolin February 4, 2025 12:49
@George-Stefan George-Stefan dismissed stale reviews from rlubos, ceolin, EmilioCBen, and decsny via 16b1f37 February 13, 2025 16:08
@George-Stefan
Copy link
Collaborator

entropy side looks good to me.

@ceolin, @rlubos , @cfriedt, @mmahadevan108
NXP HAL PR was merged so this is the final update of this PR

andrei-menzopol and others added 8 commits February 13, 2025 21:58
@andrei-menzopol @George-Stefan
drivers: entropy: add nxp ele trng
232f040 
Add NXP ELE TRNG driver

Signed-off-by: Andrei Menzopol <[email protected]>
@andrei-menzopol @George-Stefan
drivers: ieee802154: add mcxw ieee802154 driver
f3a3049 
Add mcxw ieee802154 driver
Fix compliance errors for added files.
Update function names to snake_case style.

Signed-off-by: Andrei Menzopol <[email protected]>
@andrei-menzopol @George-Stefan
dts: nxp: add ieee and trng bindings and nodes
c32efc0 
Add ieee802154 and trng bindings and nodes

Signed-off-by: Andrei Menzopol <[email protected]>
@andrei-menzopol @George-Stefan
soc: nxp: mcxw: update conditions to account for ieee driver
a0cd152 
Add ram section for ieee driver.
Use config for ieee driver.

Signed-off-by: Andrei Menzopol <[email protected]>
@andrei-menzopol @George-Stefan
samples: echo_client echo_server: add frdm_mcxw7 board overlays
74e7609 
Add frdm_mcxw7 board conf and overlay files for echo_client and
echo_server sample applications.

Signed-off-by: Andrei Menzopol <[email protected]>
@andrei-menzopol @George-Stefan
samples: echo_client echo_server: update tests
8c6716b 
Group openthread tests under the same case and add frdm_mcxw71.

Signed-off-by: Andrei Menzopol <[email protected]>
@andrei-menzopol @George-Stefan
doc: frdm_mcxw71: update documentation
3ce1e53 
Update documentation for dynamic NBU.
Add openthread application building examples.

Signed-off-by: Andrei Menzopol <[email protected]>
@George-Stefan
west.yml: update hal_nxp to support new features on MCXW71
c34688f 
- add MCXW71 NBU combo BLE LL and IEEE 802.15.4 PHY firmware blob
- fix elemu driver: undef BIT if already defined
- add mcux-secure-subsystem middleware
- add ieee_802.15.4 middleware

Signed-off-by: George Stefan <[email protected]>
@dleach02
Copy link
Member

@ceolin can we get your review?

@dleach02 dleach02 removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Feb 13, 2025
@dleach02
Copy link
Member

TSC approved the blob RFC

@kartben kartben merged commit 827a725 into zephyrproject-rtos:main Feb 14, 2025
25 of 26 checks passed
@github-actions GitHub Actions
Copy link

Hi @andrei-menzopol!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceolin ceolin ceolin approved these changes

@dleach02 dleach02 dleach02 approved these changes

@decsny decsny decsny approved these changes

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@ydamigos ydamigos Awaiting requested review from ydamigos

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@ankuns ankuns Awaiting requested review from ankuns

@jukkar jukkar Awaiting requested review from jukkar

@cfriedt cfriedt Awaiting requested review from cfriedt

@pdgendt pdgendt Awaiting requested review from pdgendt

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@axelnxp axelnxp Awaiting requested review from axelnxp

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@rlubos rlubos Awaiting requested review from rlubos

@George-Stefan George-Stefan Awaiting requested review from George-Stefan

Assignees

@ceolin ceolin

Labels
area: Crypto / RNG area: IEEE 802.15.4 area: Networking area: Samples Samples area: Sockets Networking sockets manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.