Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KW45 SoC, and KW45B41-EVK board support #82034

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

KW45 SoC, and KW45B41-EVK board support #82034

wants to merge 2 commits into from
+572 −1

Conversation

sumitbatra-nxp
Copy link
Contributor

@sumitbatra-nxp sumitbatra-nxp commented Nov 26, 2024 •
edited
Loading

There are 2 commits in this PR -

  1. Adds KW45 SoC Family support
  2. Adds KW45B41Z-EVK board support

This PR is dependent on a HAL PR - zephyrproject-rtos/hal_nxp#502
Also there is a PR dependent on this one - #84565

@zephyrbot zephyrbot added platform: NXP NXP area: SPI SPI bus area: CAN platform: NXP Drivers NXP Semiconductors, drivers area: Bluetooth area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Samples Samples labels Nov 26, 2024
@zephyrbot
Copy link
Collaborator

zephyrbot commented Nov 26, 2024 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@be4d59d zephyrproject-rtos/hal_nxp#502 zephyrproject-rtos/hal_nxp#502/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added the DNM This PR should not be merged (Do Not Merge) label Nov 26, 2024
@sjanc sjanc removed their request for review November 26, 2024 10:26
kartben
kartben requested changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two commits should really be two different PRs
What's more, the comments I made in #81559 need to be addressed, in particular the lack of copyright notices for the third party code

@Thalley Thalley removed their request for review November 26, 2024 12:10
nordicjm
nordicjm requested changes Nov 27, 2024
View reviewed changes
boards/nxp/kw45b41z_evk/Kconfig Outdated Show resolved Hide resolved
@zephyrbot zephyrbot requested a review from decsny November 27, 2024 09:33
@sumitbatra-nxp
Copy link
Contributor Author

sumitbatra-nxp commented Nov 27, 2024 •
edited
Loading

The two commits should really be two different PRs What's more, the comments I made in #81559 need to be addressed, in particular the lack of copyright notices for the third party code

@kartben .. Fixed #81559..
Wanted to ask if you agree on -

  1. Splitting this PR into 2 commits one for SoC support and another one for board
  2. For creating a separate PR for OpendroneID application since it will be dependent on this PR, I can mark PR2 as do not merge until PR1 is merged

@sumitbatra-nxp sumitbatra-nxp force-pushed the kw45-upstream1 branch 2 times, most recently from 9689ae8 to c700dbf Compare November 27, 2024 10:09
@sumitbatra-nxp sumitbatra-nxp mentioned this pull request Nov 27, 2024
Draft
@sumitbatra-nxp sumitbatra-nxp changed the title KW45 SoC, board support with OpendroneID Application KW45 SoC, and KW45B41-EVK board support Nov 27, 2024
@sumitbatra-nxp
soc: nxp: Add kw45 SoC support
98f2f58 
kw45 SoC is similar to mcxw71 with minor differences in
Radio Link Layer Interrupt and link layer configuration
and status registers.

Signed-off-by: Sumit Batra <[email protected]>
@sumitbatra-nxp
boards: nxp: Add kw45b41z-evk board support
99a0b77 
NXP KW45 EVK board support

Signed-off-by: Sumit Batra <[email protected]>
@sumitbatra-nxp sumitbatra-nxp mentioned this pull request Jan 26, 2025
Open
@sumitbatra-nxp
Copy link
Contributor Author

The two commits should really be two different PRs What's more, the comments I made in #81559 need to be addressed, in particular the lack of copyright notices for the third party code

Here we go.. I have added OpenDroneID application code in the following PR -
#84565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@dleach02 dleach02 Awaiting requested review from dleach02

@alwa-nordic alwa-nordic Awaiting requested review from alwa-nordic

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@DerekSnell DerekSnell Awaiting requested review from DerekSnell

@EmilioCBen EmilioCBen Awaiting requested review from EmilioCBen

@hermabe hermabe Awaiting requested review from hermabe

@jhedberg jhedberg Awaiting requested review from jhedberg

@nashif nashif Awaiting requested review from nashif

@rugeGerritsen rugeGerritsen Awaiting requested review from rugeGerritsen

@theob-pro theob-pro Awaiting requested review from theob-pro

@yvanderv yvanderv Awaiting requested review from yvanderv

@decsny decsny Awaiting requested review from decsny

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@nordicjm nordicjm Awaiting requested review from nordicjm

@kartben kartben Awaiting requested review from kartben

Requested changes must be addressed to merge this pull request.

Assignees

@jhedberg jhedberg

@alwa-nordic alwa-nordic

Labels
area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth area: Boards area: CAN area: Samples Samples area: SPI SPI bus DNM This PR should not be merged (Do Not Merge) manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers platform: NXP NXP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sumitbatra-nxp @zephyrbot @kartben @henrikbrixandersen @nordicjm @jhedberg @alwa-nordic