irq: multilevel: compile 3rd level IRQ APIs only when enabled #81630
Conversation
zephyrbot
requested review from
andyross,
ceolin,
cfriedt,
dcpleung,
nashif,
npitre,
peter-mitsis and
TaiJuWu
| @@ -33,18 +37,26 @@ static void test_multi_level_bit_masks_fn(uint32_t irq1, uint32_t irq2, uint32_t | |||
| zassert_equal(hwirq1, irq_parent_level(irqn, 2)); | |||
| } | |||
|
|
|||
| if (has_l3) { | |||
| #ifdef CONFIG_3RD_LEVEL_INTERRUPTS | |||
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
|
@ycsin - does this still need to be resolved? |
ycsin
force-pushed
the
pr/kconfig-multilevel-alt
branch
from
48a1ae9 to
1cbe244
Compare
|
ping @andyross @peter-mitsis |
There was a problem hiding this comment.
A couple of suggestions for doxygen.
Otherwise, just a question - do we have build asserts to verify the value of each CONFIG_*_BITS value is within reason?
E.g. 0 < L1 < 31, 0 < L2 < 31, 0 < L3 < 30, 2 <= L2 + L2 <= 32, 3 <= L1 + L2 + L3 <= 32
Some of those checks might need to be made behind an ifdef.
Also, because it wasn't immediately obvious to me, it might be worth it to comment near the L2 values in the struct that there is no need to check if L2 is enabled if multi-level is enabled
This revert the idea of 3fa7d78 from zephyrproject-rtos#78845. The 3rd level IRQ APIs won't compile when CONFIG_3RD_LEVEL_INTERRUPT_BITS=0. Updated testcases accordingly. Signed-off-by: Yong Cong Sin <[email protected]> Signed-off-by: Yong Cong Sin <[email protected]>
ycsin
force-pushed
the
pr/kconfig-multilevel-alt
branch
from
1cbe244 to
2ab2dad
Compare
The Kconfig define a range for the number of bits on each level, if their sum happen to be more than 32 bits, compilation will fail as it wont fit into
The current Kconfig allows 2ND level interrupt to be disabled when |
This revert the idea of 3fa7d78 from #78845.
The 3rd level IRQ APIs won't compile when CONFIG_3RD_LEVEL_INTERRUPT_BITS=0.
Updated testcases accordingly.
Note
This PR is the second attempt of #81318, which broke main branch CI and was reverted by #81628