Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stm32 boards with octo or quad spi nodes rename to spi node #79797

Merged
merged 4 commits into from
Jan 17, 2025
Merged

stm32 boards with octo or quad spi nodes rename to spi node #79797

merged 4 commits into from
Jan 17, 2025

Conversation

FRASTM
Copy link
Collaborator

@FRASTM FRASTM commented Oct 14, 2024 •
edited
Loading

Instead of adding a pre_dt_board.cmake to ignore spi node names when octospi or quaspi node also axists in the board device tree, This PR is changing the quadspi and octospi node names to spi@...

When building the quadspi or octospi node of a stm32 board with also spi node, this PR will avoid the following warning :

CMake Warning at ./cmake/modules/dts.cmake:415 (message):
  dtc raised one or more warnings:

  
  ./build/zephyr/zephyr.dts:1272.29-1305.5:
  Warning (spi_bus_bridge): /soc/quadspi@52005000: node name for SPI buses
  should be 'spi'

  <stdout>: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge'

fixes 79654

This was already done for the boards/st/b_u585i_iot02a/ and this PR extends to stm32 boards with octospi node:

  • stm32h7b3i_dk
  • stm32h735g_disco
  • stm32l4r9i_disco
  • stm32l562e_dk/

and quadspi node:

  • b_l4s5i_iot01a
  • stm32h745i_disco
  • stm32h747i_disco
  • stm32h750b_dk
  • stm32l476g_disco and stm32l496g_disco

decsny
decsny previously requested changes Oct 14, 2024
View reviewed changes
Copy link
Member

@decsny decsny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DT spec says to name spi bus controller nodes as spi, that's the reason for the warning, so that should be the fix instead of suppressing the warning

same as #78972

@decsny decsny requested a review from erwango October 14, 2024 13:31
@FRASTM FRASTM force-pushed the issue79654 branch 2 times, most recently from 34b84ee to 9f12730 Compare October 16, 2024 12:14
@FRASTM
Copy link
Collaborator Author

FRASTM commented Oct 16, 2024

--> changing the quadspi or octospi node name in the stm32 soc dtsi file

octospi1: spi@44021000 {
...

or

quadspi: spi@a0001000 {
...

Is it suitable for you ?

@decsny
Copy link
Member

decsny commented Oct 16, 2024

--> changing the quadspi or octospi node name in the stm32 soc dtsi file

octospi1: spi@44021000 {
...

or

quadspi: spi@a0001000 {
...

Is it suitable for you ?

yes it's what dt spec says

@FRASTM FRASTM changed the title stm32 boards with octo or quad spi nodes to ignore spi node with pre_dt_board.cmake stm32 boards with octo or quad spi nodes rename to spi node Oct 17, 2024
@FRASTM FRASTM marked this pull request as ready for review October 17, 2024 07:08
@zephyrbot zephyrbot added the platform: STM32 ST Micro STM32 label Oct 17, 2024
GeorgeCGV
GeorgeCGV previously approved these changes Oct 17, 2024
View reviewed changes
erwango
erwango requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Please also extend to xspi (H5).
And finally, boards/st/b_u585i_iot02a/pre_dt_board.cmake could also be removed.

@FRASTM
Copy link
Collaborator Author

FRASTM commented Oct 17, 2024

  • also for the xspi node of stm32H5
  • removing the boards/st/b_u585i_iot02a/pre_dt_board.cmake

@FRASTM FRASTM mentioned this pull request Oct 17, 2024
Closed
@FRASTM
Copy link
Collaborator Author

FRASTM commented Nov 5, 2024 •
edited
Loading

build failure with version v4.0.0-rc2 (not related to this PR) : west build -p auto -b b_u585i_iot02a/stm32u585xx/ns tests/benchmarks/sched_queues -- -DCONFIG_SCHED_DUMB=y

@FRASTM FRASTM mentioned this pull request Nov 5, 2024
Closed
@GeorgeCGV
Copy link
Collaborator

What stops that from being merged or simply forgotten?

@JarmouniA JarmouniA added this to the v4.1.0 milestone Nov 27, 2024
@erwango
Copy link
Member

erwango commented Nov 28, 2024

What stops that from being merged or simply forgotten?

CI failing due to zephyrproject-rtos/trusted-firmware-m#115, which was also blocked but we'll be able to make it progress now.

@GeorgeCGV
Copy link
Collaborator

@erwango ok, I thought it is "(not related to this PR)"

@mathieuchopstm mathieuchopstm mentioned this pull request Jan 13, 2025
Closed
FRASTM added 4 commits January 17, 2025 10:44
@FRASTM @kartben
dts: arm: stm32 devices with quadspi is named spi node
2a4df3a 
Fixes the CMake Warning on build/zephyr/zephyr.dts:
Warning (spi_bus_bridge): /soc/octospi@52005000: node name
for SPI buses should be 'spi'
<stdout>: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge'

Signed-off-by: Francois Ramu <[email protected]>
@FRASTM @kartben
dts: arm: stm32 devices with octospi is named spi node
f2606ee 
Fixes the CMake Warning on build/zephyr/zephyr.dts:
Warning (spi_bus_bridge): /soc/octospi@52005000: node name
for SPI buses should be 'spi'
<stdout>: Warning (spi_bus_reg): Failed prerequisite 'spi_bus_bridge'

Signed-off-by: Francois Ramu <[email protected]>
@FRASTM @kartben
dts: arm: stm32 devices with xspi is named spi node
cca5286 
Fixes the CMake Warning on build/zephyr/zephyr.dts:
Warning (spi_bus_bridge): /soc/xspi@47001400: node name
for SPI buses should be 'spi'

Signed-off-by: Francois Ramu <[email protected]>
@FRASTM @kartben
boards: st: remove the pre_dt_board wihout with ospi node
ee58f35 
Since the ospi@ node does not exist anymore for the stm32u5 device
there is no more need for this pre_dt_board.cmake file.

Signed-off-by: Francois Ramu <[email protected]>
@zephyrbot zephyrbot requested a review from djiatsaf-st January 17, 2025 09:45
@kartben kartben merged commit 8a305df into zephyrproject-rtos:main Jan 17, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeCGV GeorgeCGV GeorgeCGV approved these changes

@erwango erwango erwango approved these changes

@gautierg-st gautierg-st gautierg-st approved these changes

@mathieuchopstm mathieuchopstm mathieuchopstm approved these changes

@decsny decsny decsny left review comments

@marwaiehm-st marwaiehm-st Awaiting requested review from marwaiehm-st

@djiatsaf-st djiatsaf-st Awaiting requested review from djiatsaf-st

Assignees

@erwango erwango

Labels
platform: STM32 ST Micro STM32
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.

Warning when using flash_stm32_qspi with CONFIG_USE_MICROCHIP_QSPI_FLASH_WITH_STM32 and requires-ulbpr
9 participants
@FRASTM @decsny @GeorgeCGV @erwango @gautierg-st @mathieuchopstm @kartben @zephyrbot @JarmouniA