drivers: sensor: st: replace i2/3c_burst_write #79347
Merged
+37
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
jeppenodgaard,
MaureenHelm,
teburd,
tristan-google,
ubieda and
yperess
teburd
previously approved these changes
Oct 3, 2024
MaureenHelm
requested changes
Oct 3, 2024
XenuIsWatching
force-pushed
the
st-i2c-i2c-burst
branch
from
9d8c28e to
08ae487
Compare
ubieda
previously approved these changes
Oct 16, 2024
|
@MaureenHelm please revisit |
@MaureenHelm ping :) |
avisconti
reviewed
Jan 10, 2025
XenuIsWatching
force-pushed
the
st-i2c-i2c-burst
branch
from
08ae487 to
c2dca38
Compare
XenuIsWatching
force-pushed
the
st-i2c-i2c-burst
branch
from
c2dca38 to
210d74c
Compare
avisconti
requested changes
Jan 24, 2025
| @@ -21,6 +21,12 @@ int stmemsc_i3c_write(void *stmemsc, | |||
| uint8_t reg_addr, uint8_t *value, uint8_t len) | |||
| { | |||
| struct i3c_device_desc *target = **(struct i3c_device_desc ***)stmemsc; | |||
| uint8_t buf[17]; | |||
There was a problem hiding this comment.
Use the macro also here. Maybe using a common name among I2C and I3C?
| @@ -21,7 +21,14 @@ int stmemsc_i2c_read(const struct i2c_dt_spec *stmemsc, | |||
| int stmemsc_i2c_write(const struct i2c_dt_spec *stmemsc, | |||
| uint8_t reg_addr, uint8_t *value, uint8_t len) | |||
| { | |||
| return i2c_burst_write_dt(stmemsc, reg_addr, value, len); | |||
| uint8_t buf[CONFIG_STMEMSC_I2C_WRITE_BUFFER_SIZE]; | |||
There was a problem hiding this comment.
Actually I was expecting to use it also externally to stmemsc, so it would be better (maybe) to use it in this way:
#define STMEMSC_WRITE_BUFFER_SIZE CONFIG_STMEMSC_I2C_WRITE_BUFFER_SIZE
Or maybe it is not necessary...
XenuIsWatching
force-pushed
the
st-i2c-i2c-burst
branch
from
210d74c to
d8da7a2
Compare
i2/3c_burst_write comes with a warning where this combined write synthesized by thsi API may not be supported by all I2/3C devices. Replace with i2c_write instead with a buffer combining the address and data. The Kconfig STMEMSC_I2C_WRITE_BUFFER_SIZE was added to set the size of the buffer pushed to the stack. Signed-off-by: Ryan McClelland <[email protected]>
XenuIsWatching
force-pushed
the
st-i2c-i2c-burst
branch
from
d8da7a2 to
5f8da77
Compare
avisconti
approved these changes
Jan 29, 2025
MaureenHelm
approved these changes
Jan 29, 2025
5ae29c
added a commit
to 5ae29c/zephyr
that referenced
this pull request
Feb 3, 2025
Previously, the Kconfig option CONFIG_STMEMSC_I3C_I2C_WRITE_BUFFER_SIZE has been introduced to replace i2c_burst_write with i2c_write using a buffer combining the address and data. See zephyrproject-rtos#79347 Add missing buffer size config to stmemsc_i2c_write_incr to replace fixed buffer size. Signed-off-by: Jonas Spinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i2/3c_burst_write comes with a warning where this combined write synthesized by thsi API may not be supported by all I2/3C devices. Replace with i2c_write instead with a buffer combining the address and data.