Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: i3c: add synopsys designware i3c driver #64528

Merged
merged 3 commits into from
Feb 14, 2025
Merged

drivers: i3c: add synopsys designware i3c driver #64528

merged 3 commits into from
Feb 14, 2025

Conversation

XenuIsWatching
Copy link
Member

@XenuIsWatching XenuIsWatching commented Oct 28, 2023 •
edited
Loading

This implements the initial driver for the synopsys designware i3c IP.

@XenuIsWatching XenuIsWatching force-pushed the i3c-dw branch 3 times, most recently from 51bf79c to 6c6f520 Compare October 29, 2023 21:13
@carlescufi carlescufi requested review from anangl and gmarull November 2, 2023 12:58
@XenuIsWatching XenuIsWatching force-pushed the i3c-dw branch 3 times, most recently from 20f8871 to b13970d Compare November 17, 2023 01:47
@aspeeddylan
Copy link
Contributor

Is it possible to add platform-specific infrastructure, as has been done in the Linux kernel?

torvalds/linux@d782188

@XenuIsWatching
Copy link
Member Author

Is it possible to add platform-specific infrastructure, as has been done in the Linux kernel?

torvalds/linux@d782188

I don't know how you would want that within Zephyr. That appears to be Linux OS specific stuff....

@XenuIsWatching XenuIsWatching force-pushed the i3c-dw branch 3 times, most recently from edb7e2f to 0a5f3ce Compare March 8, 2024 08:37
@XenuIsWatching XenuIsWatching force-pushed the i3c-dw branch 3 times, most recently from a8c0fdb to 258ac7d Compare March 20, 2024 05:36
@XenuIsWatching
Copy link
Member Author

An update on this... I can no longer work on this as I have had a "change in direction" internally.
This PR is still up if anyone wants to 'take over' and debug and test (which I never got around to doing).

@XenuIsWatching XenuIsWatching force-pushed the i3c-dw branch 7 times, most recently from 3ef020b to 6d7393e Compare April 7, 2024 01:39
@XenuIsWatching
Copy link
Member Author

XenuIsWatching commented Apr 7, 2024 •
edited
Loading

This appears to be the most complete of all the Synopsys I3C PRs out there (although I may be biased towards myself 😛 ) As this does support target mode, IBI TIRs, HDR-DDR, HDR-TSP, HDR-TSL, proper attachment and detachment of devices, and short CCCs. I have heard from some that they have planned to try this out.... although no timeline is known.

@XenuIsWatching XenuIsWatching force-pushed the i3c-dw branch 2 times, most recently from 13b36fe to d33aec0 Compare April 8, 2024 15:06
@XenuIsWatching XenuIsWatching force-pushed the i3c-dw branch 2 times, most recently from 341a3c9 to 4327ce6 Compare January 29, 2025 09:44
@Shreehari-AlifSemi Shreehari-AlifSemi mentioned this pull request Jan 30, 2025
Merged
HemanthKumar-AlifSemi pushed a commit to alifsemi/zephyr_alif that referenced this pull request Feb 3, 2025
@XenuIsWatching @HemanthKumar-AlifSemi
drivers: i3c: add synopsys designware i3c driver
f237b2e 
Add synopsys designware i3c driver
Ported down the driver available at "zephyrproject-rtos/zephyr#64528"
from v4.0 to v3.6

Signed-off-by: Ryan McClelland <[email protected]>
Signed-off-by: shreehari <[email protected]>
@Shreehari-AlifSemi
Copy link

@Shreehari-AlifSemi I appreciate your interest in our code and the effort you put into testing the target feature! Regarding your request for attribution, most of the changes you referenced had incompatibility issues with handoff support and couldn’t be integrated. As a result, only about 10 code lines were retained, which is quite minor and typically wouldn’t warrant adding a new license header. Copyright is typically reserved for substantial contributions

I disagree to this.

@HemanthKumar-AlifSemi
Copy link

All,

Why is this pull request taking a long time to review and merge?

xodus7
xodus7 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@xodus7 xodus7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been using this driver in our project for a while now.

@XenuIsWatching XenuIsWatching requested review from cfriedt and dkalowsk and removed request for Shreehari-AlifSemi February 12, 2025 01:21
ycsin
ycsin previously approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@ycsin ycsin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, 2023?😅

Code looks clean to me

cfriedt
cfriedt previously approved these changes Feb 13, 2025
View reviewed changes
@dcpleung
Copy link
Member

Could you move the changes under tests/ from first commit to the last commit?

dkalowsk
dkalowsk previously approved these changes Feb 13, 2025
View reviewed changes
nashif
nashif previously approved these changes Feb 13, 2025
View reviewed changes
dcpleung
dcpleung previously approved these changes Feb 13, 2025
View reviewed changes
@XenuIsWatching
drivers: i3c: add synopsys designware i3c driver
30a6f95 
Add synopsys designware i3c driver

Signed-off-by: Ryan McClelland <[email protected]>
@XenuIsWatching
drivers: i3c: add snps_designware_i3c to i3c shell
d13d35c 
add the synopsys designware i3c to the i3c shell.

Signed-off-by: Ryan McClelland <[email protected]>
@XenuIsWatching
tests: drivers: build_all: add build for i3c_dw
87c4b28 
The Synopsys I3C has no in-tree board with it to built with. This
adds a test build-only for the cadence i3c peripheral attaching
with the qemu_cortex_m3 board as that appears to be generic
enough.

Signed-off-by: Ryan McClelland <[email protected]>
@XenuIsWatching
Copy link
Member Author

Could you move the changes under tests/ from first commit to the last commit?

done

@kartben kartben merged commit ed9c6d8 into zephyrproject-rtos:main Feb 14, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdgendt pdgendt pdgendt left review comments

@syedsk syedsk syedsk left review comments

@Shreehari-AlifSemi Shreehari-AlifSemi Shreehari-AlifSemi left review comments

@nashif nashif nashif approved these changes

@dkalowsk dkalowsk dkalowsk approved these changes

@xodus7 xodus7 xodus7 approved these changes

@dcpleung dcpleung dcpleung approved these changes

@cfriedt cfriedt cfriedt left review comments

@ycsin ycsin ycsin left review comments

@anangl anangl Awaiting requested review from anangl

@galak galak Awaiting requested review from galak

@decsny decsny Awaiting requested review from decsny

@gmarull gmarull Awaiting requested review from gmarull

Assignees

@dcpleung dcpleung

Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: I3C
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.