-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for specifying the workspace manifest file name #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just a minor comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, can you squash the fix into the first commit? (and force push) Realized now you made two separate commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this repo has a nice README with example scenarios, may I suggest you add one entry illustrating how to use the manifest-file-name
?
Note: if this is to be released in a future version of the action (@v2
?), the samples in the README will need updating at some point to use this new version identifier.
Since the change is backward compatible I would just tag it as |
Just added a commit with this. |
There is a minor typo ("REAMDE") in the commit message, but looks good otherwise, thanks! Might even make sense to just squash everything into just one commit TBH |
Includes an additional scenario illustrating a custom manifest file name in the README file.
Alright, just did this. |
@sense-Jo just pushed the v1.0.2 tag past this and updated v1 to point to it as well, so this is now live. Cheers. |
West supports specifying the name of the workspace manifest file name when initializing a workspace. A use case for this would be a Zephyr application which can be build with vanilla Zephyr and nRF Connect SDK.