Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregate SQLAlchemy-based DB management in wordprofile.db #15

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

gremid
Copy link
Member

@gremid gremid commented Jan 9, 2025

No description provided.

@gremid gremid requested a review from knit-bee January 9, 2025 08:43
@gremid gremid self-assigned this Jan 9, 2025
@gremid gremid force-pushed the feature/sqlalchemy-refactoring branch from ebd3609 to edb07ad Compare January 9, 2025 08:45
Copy link
Member

@knit-bee knit-bee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the refactoring! Changing the index creation is something I have wanted to do for quite time. It is much more concise now and better structured.

wordprofile/db.py Outdated Show resolved Hide resolved
wordprofile/db.py Outdated Show resolved Hide resolved
wordprofile/db.py Show resolved Hide resolved
wordprofile/db.py Outdated Show resolved Hide resolved
@gremid gremid force-pushed the feature/sqlalchemy-refactoring branch from edb07ad to 990fd3f Compare January 10, 2025 08:32
@gremid gremid merged commit 990fd3f into master Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants