-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement implicit authentication for ACR and Storage Account #3274
base: develop
Are you sure you want to change the base?
feat: implement implicit authentication for ACR and Storage Account #3274
Conversation
Signed-off-by: Lukas Reining <[email protected]>
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The style guide flagged several spelling errors that seemed like false positives. We skipped posting inline suggestions for the following words:
- Entra
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
Hey @lukas-reining, thanks for the PR! I took a look already and like it, but we would need @stefannica (our service connector expert :) ) to take a look before merging this. He's currently out on vacation but will be back next week at which point you'll get more feedback on this. |
Thanks, sounds good! @schustmi could you please approve the pending checks/pipeline to run? They do not run automatically as this is my first PR to the repo. |
Signed-off-by: Lukas Reining <[email protected]>
I fear you have to approve them again @schustmi :/ |
Describe changes
Implements implicit authentication for ACR and Storage Account.
Implicit authentication has not been available for ACR and Storage Account yet as seen #3269.
For ACR, admin account is still used as a fallback if AD authentication vie the default credential fails, to make this change non-breaking.
Fixes #3269
Pre-requisites
Please ensure you have done the following:
develop
and the open PR is targetingdevelop
. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.Types of changes