Skip to content

Commit

Permalink
fix diff gauss error
Browse files Browse the repository at this point in the history
  • Loading branch information
zeng-yifei committed Jun 20, 2024
1 parent efd5c04 commit da04c4b
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@

# Update

6.20: IMPORTANT. Fix the bug caused by new version of diff_gauss. Newest version of diff_gauss use `color, depth, norm, alpha, radii, extra` as an output. However, previous version use `color, depth, alpha, radii` as an output. Using older version of this code will cause mismatch error and may misuse normal for the alpha loss, resulting in bad results.

5.26: Update Text/Image to 4D data below.

5.21: Fix RGB loss into the batch loop. Add visualize code.
Expand Down
4 changes: 2 additions & 2 deletions gs_renderer_4d.py
Original file line number Diff line number Diff line change
Expand Up @@ -885,15 +885,15 @@ def render(
shs = self.gaussians.get_features

# Rasterize visible Gaussians to image, obtain their radii (on screen).
rendered_image, rendered_depth, rendered_alpha, radii = rasterizer(
rendered_image, rendered_depth, normal, rendered_alpha ,radii, _ = rasterizer(
means3D = means3D_final,
means2D = means2D,
shs = shs,
colors_precomp = colors_precomp,
opacities = opacity_final,
scales = scales_final,
rotations = rotations_final,
cov3D_precomp = cov3D_precomp)
cov3Ds_precomp = cov3D_precomp)


return {
Expand Down
6 changes: 2 additions & 4 deletions main.py
Original file line number Diff line number Diff line change
Expand Up @@ -303,17 +303,15 @@ def train_step(self):

images = []
poses = []
vers, hors, radii = [], [], []

vers_plus, hors_plus, radii_plus = [], [], []
self.guidance_zero123.update_step(1,self.step)
# render random view
ver = np.random.randint(min_ver, max_ver)
hor = np.random.randint(-180, 180)
radius = 0

vers.append(ver)
hors.append(hor)
radii.append(radius)




Expand Down

0 comments on commit da04c4b

Please sign in to comment.