Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Fix issue #159 #190

Merged
merged 2 commits into from
May 6, 2015
Merged

Fix issue #159 #190

merged 2 commits into from
May 6, 2015

Conversation

seyfer
Copy link
Contributor

@seyfer seyfer commented May 6, 2015

Ocramius
Ocramius reviewed May 6, 2015
View reviewed changes
src/ZendDeveloperTools/Profiler.php
@@ -146,7 +146,7 @@ public function getEvent()
*/
public function setEventManager(EventManagerInterface $eventManager)
{
$eventManager->addIdentifiers(array(__CLASS__, get_called_class(), 'profiler'));
$eventManager->addIdentifiers([__CLASS__, get_called_class(), 'profiler']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use PHP 5.4 syntax

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, I will fix it now

@seyfer
Copy link
Contributor Author

seyfer commented May 6, 2015

Last commit fix 5.4 syntax back to 5.3

@Ocramius
Copy link
Member

Ocramius commented May 6, 2015

👍

Ocramius added a commit that referenced this pull request May 6, 2015
@Ocramius
Merge pull request #190 from seyfer/master
d343268 
Fix issue #159
@Ocramius Ocramius merged commit d343268 into zendframework:master May 6, 2015
@Ocramius Ocramius self-assigned this May 6, 2015
@samsonasik
Copy link
Contributor

@Ocramius related with #178 ?

@Ocramius
Copy link
Member

Ocramius commented May 6, 2015

Not sure. Isn't that a different problem? (related, but different)

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 6 May 2015 at 16:39, Abdul Malik Ikhsan [email protected] wrote:

@Ocramius https://github.com/Ocramius related with #178
#178 ?

—
Reply to this email directly or view it on GitHub
#190 (comment)
.

@samsonasik
Copy link
Contributor

That's I think different. but actually fix factory issue

Warm regards,

Abdul Malik Ikhsan

Pada 6 Mei 2015, pukul 22.41, Marco Pivetta [email protected] menulis:

Not sure. Isn't that a different problem? (related, but different)

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

On 6 May 2015 at 16:39, Abdul Malik Ikhsan [email protected] wrote:

@Ocramius https://github.com/Ocramius related with #178
#178 ?

—
Reply to this email directly or view it on GitHub
#190 (comment)
.

—
Reply to this email directly or view it on GitHub.

@samsonasik
Copy link
Contributor

@Ocramius I think we can have a tag ? 1.0.0 release ?

@samsonasik samsonasik mentioned this pull request May 6, 2015
Closed
@Ocramius Ocramius added this to the 1.0.0-RC1 milestone Oct 30, 2015
@Ocramius Ocramius mentioned this pull request Oct 30, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@Ocramius Ocramius

Labels
None yet
Projects
None yet
Milestone
1.0.0-RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@seyfer @Ocramius @samsonasik