Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Refactor of Zend\Db\TableGateway for 3.0.0 #372

Open
wants to merge 33 commits into
base: 3.0.0
Choose a base branch
from
Open

Refactor of Zend\Db\TableGateway for 3.0.0 #372

wants to merge 33 commits into from

Conversation

arueckauer
Copy link
Contributor

This PR provides changes described in #361

arueckauer added 30 commits March 14, 2019 13:49
@arueckauer
Updated file header comment, added strict_types declaration
aff51f6
@arueckauer
Removed DocBlock for non-existing argument
da240f7
@arueckauer
Defined access modifier for class constants
c8d67b9
@arueckauer
Removed unnecessary parentheses
36a09d8
@arueckauer
Removed senseless return statement
58aa292
@arueckauer
Makes usage of compact()
d64052e
@arueckauer
Removed redundanct variables
56e4064
@arueckauer
Use ::class instead
f976f59
@arueckauer
Use static::class instead
32c592f
@arueckauer
Declared return types
ac63430
@arueckauer
Initialize string property as string
4890d50
@arueckauer
Updated possible types for
860da62
@arueckauer
Write single-line comments with @var as one-liners
f9b6214
@arueckauer
Do not align @param tags
5e5af61
@arueckauer
Write single-line comments with @var as one-liners, removed null init…
6ed30ef 
…ialization, fixed duplicate return type declarations
@arueckauer
Removed comment
77e045e
@arueckauer
Removed comment which does not add valuable information, import Array…
d0b743f 
…Access
@arueckauer
Added information on where type declarations are blocked
1c37347
@arueckauer
Removed comments which do not add valuable information, updated type …
b5a668c 
…declarations, removed null initializations
@arueckauer
Added/updated argument and return type declarations, removed unnecess…
42b3f89 
…ary method comments
@arueckauer
Removed unnecessary comments
4e8996b
@arueckauer
Nullable and optional arguments, which are marked as = null, must hav…
e7c1ca3 
…e the ? symbol present
@arueckauer
Removed null initializations, removed unnecessary comments
f6b2c1c
@arueckauer
Removed null initializations, removed unnecessary comments
7cc7a81
@arueckauer
Declared argument types, removed unnecessary comments, updated return…
67d4518 
… type hints in DocBlock
@arueckauer
Removed unnecessary comments, declared argument types
c476b86
@arueckauer
Removed empty line
8c29ecd
@arueckauer
Comment tags @param, @throws and @return should not be aligned or con…
3b1c803 
…tain multiple spaces between the tag, type and description
@arueckauer
Removed null initializations
e45af7c
@arueckauer
Apply strict comparison
d4b0340
@weierophinney weierophinney mentioned this pull request Dec 31, 2019
Closed
@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#10.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-db to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-db.
  • In your clone of laminas/laminas-db, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arueckauer @weierophinney