Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Fixes #316 : set return null for HydratingResultSet::current() on no data #325

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

samsonasik
Copy link
Contributor

@samsonasik samsonasik commented Jul 3, 2018

Provide a narrative description of what you are trying to accomplish:

  • Are you fixing a bug?
    • Detail how the bug is invoked currently.
      call HydratingResultSet::current() on no data in current record.
    • Detail the original, incorrect behavior.
      it returns false.
    • Detail the new, expected behavior.
      it returns null, the "AbstractResultset" and "ResultSet" class returns null on no data, so it returns null for consistency/fix.
    • Base your feature on the master branch, and submit against that branch.
    • Add a regression test that demonstrates the bug, and proves the fix.
    • Add a CHANGELOG.md entry for the fix.

If this is considered a BC break, I can target to develop. Fixes #316

samsonasik added a commit to samsonasik/zend-db that referenced this pull request Jul 3, 2018
@ezimuel ezimuel added this to the 2.10.0 milestone Aug 7, 2018
@ezimuel
Copy link
Contributor

ezimuel commented Aug 7, 2018

@samsonasik yes, this is a BC break. Please send it to develop. Thanks!

@samsonasik samsonasik changed the base branch from master to develop August 7, 2018 13:02
@samsonasik
Copy link
Contributor Author

@ezimuel I've rebased against develop branch and change target to develop branch.

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-db; a new issue has been opened at laminas/laminas-db#30.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-db. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-db to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-db.
  • In your clone of laminas/laminas-db, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants