-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for range requests to Fetch
#182
Conversation
One issue that will likely need to be fixed is making sure the cache can keep track of which ranges have been fetched. At the moment, the un-fetched ranges would be zeroed out, and the current behavior would result in a read of the zeroed data without fetching it first. @zardoy, this will likely tie into streaming zip files, or at least fetching them in parts. @coder0107git mentioned this in zen-fs/archives#3. Do either of you have any feedback? @mcandeia, I know you aren't using |
I just want zip data so badly. Yes making fetch automatically work with this would be beneficial |
I think a nice solution to the caching problem I mentioned earlier is adding the |
The actual support for range requests has been implemented over on Utilium (james-pre/utilium@4c82012) so it can be used in other projects (not just ZenFS). |
Sorry I meant zip data streaming (zen-fs/archives#3) |
This is a PR to track the progression of #53.
The implementation in 50e600d involves some changes to transactions that are not backwards type compatible and not runtime forward compatible. Due to the significance of these changes, I've labeled the PR as breaking.
Tests have not been changed at all and are passing, so that is good at least.