Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workspace: Add function to save new file in directory nearest tab #22563

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

workspace: Add function to save new file in directory nearest tab #22563

wants to merge 2 commits into from
+59 −7

Conversation

CharlesChen0823
Copy link
Contributor

@CharlesChen0823 CharlesChen0823 commented Jan 2, 2025 •
edited
Loading

Closes #15685

Release Notes:

  • save new file in directory neasrest tab

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 2, 2025
@maxdeviant maxdeviant changed the title workspace: Add function for save new file in directory nearest tab workspace: Add function to save new file in directory nearest tab Jan 2, 2025
@CharlesChen0823
Copy link
Contributor Author

CharlesChen0823 commented Jan 3, 2025 •
edited
Loading

There is still an edge case, when save file in split pane with no nearest tab behaviour not save with vscode.

Don't have find better method for this edge case, Does someone have better idea?

the cannot be ready review, beceacuse the last_active_center_pane not work as I expected what i said in #22604, I will fix #22604 and then this pr will ready for review.

@CharlesChen0823 CharlesChen0823 marked this pull request as ready for review January 3, 2025 07:08
@CharlesChen0823 CharlesChen0823 mentioned this pull request Jan 3, 2025
Closed
@CharlesChen0823 CharlesChen0823 marked this pull request as draft January 4, 2025 11:32
@ConradIrwin
Copy link
Member

@CharlesChen0823 Thanks for this!

I think it would be better to make this the default (like Sublime) than to have two different approaches for the same thing.

@ConradIrwin ConradIrwin self-assigned this Jan 7, 2025
@CharlesChen0823
Copy link
Contributor Author

I think it would be better to make this the default (like Sublime) than to have two different approaches for the same thing.

I'm not understand what's your meaning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ConradIrwin ConradIrwin

Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save new file in directory of previous tab
2 participants
@CharlesChen0823 @ConradIrwin