Skip to content

Commit

Permalink
Add Support for ActiveRecord Proxy Adapters
Browse files Browse the repository at this point in the history
  • Loading branch information
stingrayzboy committed Jan 8, 2025
1 parent 2f61ccd commit 2cee921
Show file tree
Hide file tree
Showing 6 changed files with 15 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ jobs:
bundle exec rake test:postgis
bundle exec rake test:postgresql
bundle exec rake test:postgresql_makara
bundle exec rake test:postgresql_proxy_adapter
- name: Run tests with seamless_database_pool
run: |
bundle exec rake test:seamless_database_pool
Expand Down
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
## Changes in 2.1.0
### New Features

* Add Support for `active_record_proxy_adapters` gem. Since Rails 7.1 and above the support for
makara is gone. It is no longet maintained. Developers are left struggling. folks over at @nasdaq have written a gem called
[active_record_proxy_adapters](https://rubygems.org/gems/active_record_proxy_adapters) which
does the same thing. Since this gem has its own adapter called `postgresql_proxy` we need to add the same as per the discussions [here.](https://github.com/Nasdaq/active_record_proxy_adapters/issues/20)

## Changes in 2.0.0

### Breaking Changes
Expand Down
1 change: 1 addition & 0 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ ADAPTERS = %w(
jdbcpostgresql
postgresql
postgresql_makara
postgresql_proxy_adapter
postgis
makara_postgis
sqlite3
Expand Down
1 change: 1 addition & 0 deletions lib/activerecord-import/base.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ def self.base_adapter(adapter)
when 'mysql2spatial' then 'mysql2'
when 'spatialite' then 'sqlite3'
when 'postgresql_makara' then 'postgresql'
when 'postgresql_proxy' then 'postgresql'
when 'makara_postgis' then 'postgresql'
when 'postgis' then 'postgresql'
when 'cockroachdb' then 'postgresql'
Expand Down
2 changes: 1 addition & 1 deletion lib/activerecord-import/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

module ActiveRecord
module Import
VERSION = "2.0.0"
VERSION = "2.1.0"
end
end
3 changes: 3 additions & 0 deletions test/adapters/postgresql_proxy_adapter.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# frozen_string_literal: true

ENV["ARE_DB"] = "postgresql"

0 comments on commit 2cee921

Please sign in to comment.