hack: retry commands to avoid throttling #208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As discussed elsewhere, I think what is happening in your case is repeated In the short term I believe we'll raise a specific exception, allowing the caller to back off and try again if they believe the failure to be temporary. I've also created #210 to explore doing this automatically under some circumstances. |
|
Fair enough, this workaround works for me since I prefer to poll to get a response as quick as possible, but I will admit its kinda inelegant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #137 (comment)
Not sure if this is the preferred approach, a fixed timeout between commands seems wasteful since the desktop client performance apparently improves over time. Polling as implemented here will generate some extra log spam, but I guess it could also be turned off.